Problem/Motivation

Currently, OrangeDamApi::getKeywords() retrieves keywords, packages them as OrangeDamKeywordItems and Queues them. The latter two operations should be handled by OrangeDamQueueDataManager.

Since the only two calls to OrangeDamApi:getKeywords() are in OrangeDamQueueDataManager, resolving this is pretty straightforward. This allows OrangeDamApi::getKeywords() to do _only_ what it says on the label, and, once the queueing is moved over to OrangeDamQueueDataManager still allows the application to behave exactly as before.

Proposed resolution

Move the following code to OrangeDamQueueDataManager:

        $this->migrationDataManager->queueMigrationItem($keyword);

Remaining tasks

Create a merge request with the suggested improvement.

User interface changes

Will allow implementors to use OrangeDamApi to just retrieve data, without also queuing it.

API changes

none.

Data model changes

none

Issue fork orange_dam-3441899

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

apotek created an issue. See original summary.

apotek’s picture

Issue summary: View changes

apotek’s picture

Status: Active » Needs review

  • apotek committed 1b16ab26 on 1.x
    Issue #3441899 by apotek: Make OrangeDamApi::getKeywords a pure get...
apotek’s picture

Status: Needs review » Reviewed & tested by the community

Full migration tests were run. Everything checked out.

apotek’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.