[1.23] Known issued in modules used in the profile [#2704465]

Problem/Motivation

This module uses i18n_strings, i18n_rules and others. There is a known incompatibility between them that causes issues on install, preventing it with an error. See this for details: #2495599: PHP Fatal error: Class name must be a valid object or a string in i18n_string module.

There is another issue on a module used in the profile (og_quiz): #2710875: [1.5] Drush registry-rebuild causes registry corruption.

Multyselect module is out of date (2 bug-fix releases behind). They are fixing UI breakages on form validation errors.

Performance issue in crumbs module: #2721687: Function user_roles executed too often.

Critical performance issue in h5p module. I've seen sites go down because of issues similar to this one: #2722407: Excessive calls to variable_set

Proposed resolution

Update Profile's make accordingly.

Remaining tasks

Patch, review, RTBC, commit.

User interface changes

None.

API changes

None.

Data model changes

None.

Comment	File	Size	Author
#2	opigno_lms-incompatible-modules-2704465-D7-2.patch	498 bytes	ndobromirov

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

12 April 2016 at 08:12

ndobromirov created an issue. See original summary.

Comment #2

ndobromirov CreditAttribution: ndobromirov commented 12 April 2016 at 08:22

Issue summary:	View changes
Status:	Needs work	» Needs review

File	Size
opigno_lms-incompatible-modules-2704465-D7-2.patch	498 bytes

Here is a patch for it.

Comment #3

ndobromirov CreditAttribution: ndobromirov commented 21 April 2016 at 14:36

Issue summary:

View changes

Comment #4

ndobromirov CreditAttribution: ndobromirov commented 21 April 2016 at 14:37

Title:	Incompatible modules in the profile.	» Known issued in modules used in the profile
Issue summary:	View changes
Issue tags:		+DX (Developer Experience)

Comment #5

ndobromirov CreditAttribution: ndobromirov commented 3 May 2016 at 14:04

Issue summary:

View changes

Comment #6

ndobromirov CreditAttribution: ndobromirov commented 11 May 2016 at 10:09

Issue summary:

View changes

Comment #7

amermod CreditAttribution: amermod at Connect-i commented 12 May 2016 at 14:06

Title:	Known issued in modules used in the profile	» [1.23] Known issued in modules used in the profile
Priority:	Major	» Normal
Status:	Needs review	» Active

Hi ndobromirov,

For the first problem, I was not able to reproduce the bug with the latest version of Opigno LMS (1.22). I saw that the issue #2495599: PHP Fatal error: Class name must be a valid object or a string in i18n_string module is using and older version of Drupal and of the module Entity. Maybe that is why I cannot reproduce the error.

The second problem is now fixed and ready for the next release.

We are aware about the Multiselect, but their new version break some features on Opigno LMS and we will have to do some dev in order to fix this, but it is not worth the time for now. It will certainly be in our next release thought.

Finally, for the performance problems, I prefer to wait for their release before adding it to our next release. I will not patch something not approved by the module's developers, knowing that theses modules are still in active development.