as it says on the tin.

Comments

tmcw’s picture

tmcw CreditAttribution: tmcw commented
Priority: Normal » Critical
tmcw’s picture

tmcw CreditAttribution: tmcw commented

I'm starting to think that this is best implemented as a different control than popup. The implementation of popups in OpenLayers is lackluster and poorly designed for this usage.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Though not the best code in the world, I do enjoy the tooltip that is in 1.x.

toomanypets’s picture

toomanypets CreditAttribution: toomanypets commented

Subscribe.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Hey @tmcw, what about aiming to base the tooltips from the tooltips that are implemented in openlayers_plus?

http://github.com/developmentseed/openlayers_plus

steinmb’s picture

steinmb CreditAttribution: steinmb commented

One more annoying subscribe :)
What can we do to help getting this 4 months old critical issue fixed? Thanx for a great module by the way.

tmcw’s picture

tmcw CreditAttribution: tmcw commented

steinmb: in the meantime, you can just use the openlayers_plus module, that's what many big users are doing.

I'm not sure about what the gameplan should be here. My potential idea is to rewrite the parts of the openlayers_plus behavior into Drupal-independent and jQuery-independent code and pitch them as an addition to OpenLayers proper. The main problem is that it's unsightly and wrong to maintain great amounts of unabstracted javascript code in this module.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Though I agree with trying to minimize JS in this module, I think:

* Trying to get an adequate tooltip in upstream would take some significant time and effort (assumingly)
* The current solution is really no good (we should at the very least remove it; maybe see if someone wants to put this in an outside module or just point to openlayers_plus)
* This seems like a valid case for creating our own basic solution, as it is a desired, general-enough feature, without an adequate solution in OL

steinmb’s picture

steinmb CreditAttribution: steinmb commented

@tmcw: Thanx! :) I did not know that this module existed, perhaps create a link at the project page linking to this project at Github?

I agree that that maintaing a great amount of js code is not the way forward. Perhaps do go the same way that the WYSIWYG module and other have. A wrapper module with the minimum settings req. like user feedback that the js code was found and what version and perhaps dependency warnings if the user switch to a unsupported version. The js code is kept outside the module in site/all/library/[something].

I know this adds another step to get everything up and running but then again OL not a turnkey solution anyway.

davidhk’s picture

davidhk CreditAttribution: davidhk commented

Is "hover from point to popup box" a popular requirement?

I'd rather not have it - it seems more confusing. eg on a map with many markers, there's often a marker between the current marker and the content of the popup. What happens if a user moves their cursor from first marker over the intermediate marker? Should we show the new hover (what I'd expect), or ignore it in case the user is moving to the popup?

tmcw’s picture

tmcw CreditAttribution: tmcw commented

It's at least a commonly-requested option: if points are only hoverable (not clickable) and contain groups of items, there is no other way to navigate to individual items from a map.

tmcw’s picture

tmcw CreditAttribution: tmcw commented
Title: User can't hover from point to popup box with Tooltips » Import new Popups implementation into OpenLayers
Category: bug » task
zzolo’s picture

zzolo CreditAttribution: zzolo commented

Hey @tmcw, what is "new Popups implementation" in this case? The original issue was concerning tooltips.

tmcw’s picture

tmcw CreditAttribution: tmcw commented

Er, between popups and tooltips, similar thing. Anyway, the point of this ticket is to import the openlayers_plus implementation of tooltips into this module. Or to make the openlayers_plus impl immediately usable for others.

tmcw’s picture

tmcw CreditAttribution: tmcw commented
Status: Active » Closed (works as designed)

Closing - we've agreed elsewhere that, despite the low quality of many OpenLayers components, the task of improving upon them is for other modules, not this one.