Added options for opacity, point radius, label outline, label color and label opacity for all three states.

CommentFileSizeAuthor
#3 cluster_style_options_stroke.patch9.72 KBcaktux
cluster_style_options.patch8.27 KBcaktux
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, cluster_style_options.patch, failed testing.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

Hi,

This could be a great patch but it still needs work.

  1. See why the testbot failed, why the patch doesn't apply correctly ?
  2. Add a small description of each added fields and what's the default value in the description.
  3. I think the JS part needs to cast value. If you set a string for an integer, it might crash.

Thanks !

caktux’s picture

caktux CreditAttribution: caktux commented
Status: Needs work » Needs review
FileSize
cluster_style_options_stroke.patch9.72 KB

Testbot needs git patches... Added stroke color options.

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented

Excellent patch, I'll review all of this when I have a bit more time, probably at the Drupalcamp Dublin.

Thank you very much !

Status: Needs review » Needs work

The last submitted patch, cluster_style_options_stroke.patch, failed testing.

acbramley’s picture

acbramley CreditAttribution: acbramley commented
Status: Needs work » Needs review

#3: cluster_style_options_stroke.patch queued for re-testing.

acbramley’s picture

acbramley CreditAttribution: acbramley commented

Woo, tests now pass with the latest dev release. We needed this for IE compatibility for our cluster styling. Applies cleanly to latest dev release. Thanks a lot

Pol’s picture

Pol
the/that
Location Brussels
CreditAttribution: Pol commented
Status: Needs review » Fixed

Thank you very much, committed !

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.