I just started a fresh D7 installation to test the new 7.x-rc1 for this module. I installed it and the xrds_simple requirement and then attempted to login via slashdot.org/login.pl and stackexchange.com. Both generated some notice errors and a PDOException. In order from the watchdog report:

Notice: Trying to get property of non-object in openid_provider_xrds() (line 319 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.module).

Notice: Undefined index: openid.assoc_handle in openid_provider_authentication_response() (line 181 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).

Notice: Undefined index: openid.session_type in _openid_provider_association_create() (line 52 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'session_type' cannot be null: INSERT INTO {openid_provider_association} (assoc_handle, assoc_type, session_type, mac_key, created, expires_in) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5); Array ( [:db_insert_placeholder_0] => 2012-01-30T16:33:31ZKAZK [:db_insert_placeholder_1] => HMAC-SHA256 [:db_insert_placeholder_2] => [:db_insert_placeholder_3] => b4Z/nss5B3VpySIQTkMN2C5JzSjKBRRyl5LjSrQsqBI= [:db_insert_placeholder_4] => 1327941211 [:db_insert_placeholder_5] => 3600 ) in _openid_provider_association_create() (line 105 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).

Comments

anarcat’s picture

anarcat CreditAttribution: anarcat commented

I admit I am not testing D7 very wel, thanks for the heads up. This is probably something simple.

By the way, i think you leaked a secret key there, be careful about your pastes!

jwineinger’s picture

jwineinger CreditAttribution: jwineinger commented

I'm not worried. This is a demo site just to test this stuff.

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Active » Patch (to be ported)

Could you try commit 9a7efea? I think this is just handling the corner case of private associations.

This works on D6, but the error messages should go away anyways, so this needs to be backported if it works.

jwineinger’s picture

jwineinger CreditAttribution: jwineinger commented
Status: Patch (to be ported) » Active

Ok that fixed the PDO error. I'm still seeing the following notices though:

Notice: Trying to get property of non-object in _openid_provider_signature() (line 418 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).
Notice: Trying to get property of non-object in _openid_provider_signature() (line 419 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).
Notice: Undefined index: openid.assoc_handle in openid_provider_authentication_response() (line 187 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).

anarcat’s picture

anarcat CreditAttribution: anarcat commented
Status: Active » Fixed

Alright! I have pushed more changes that should fix those warnings and improve some corner cases. Can you try the git version again?

jwineinger’s picture

jwineinger CreditAttribution: jwineinger commented

Still getting the following:

Notice: Undefined index: openid.assoc_handle in openid_provider_authentication_response() (line 195 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).
Notice: Undefined index: error_code in openid_provider_authentication_response() (line 199 of /var/www/drupal/sites/all/modules/openid_provider/openid_provider.inc).

What other debugging info do you need? I have debugging turned on but the watchdog messages don't give you much more than this.

anarcat’s picture

anarcat CreditAttribution: anarcat commented

Those errors should be harmless, but I have fixed them in git.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

reformat

DiDebru’s picture

DiDebru
Primary language German
CreditAttribution: DiDebru commented

I got still the following notices

Notice: Trying to get property of non-object in _openid_provider_signature() (Zeile 561 von/sites/all/modules/contrib/openid_provider/openid_provider.inc).
Notice: Trying to get property of non-object in _openid_provider_signature() (Zeile 562 von /sites/all/modules/contrib/openid_provider/openid_provider.inc).

Extension : openid_provider
Project : openid_provider
Type : module
Title : Openid Provider
Description : OpenID Provider (or server) support allows you to
login to other OpenID enabled sites using your local
account.
Version : 7.x-1.0+4-dev
Date : 2013-10-01
Package : OpenID
Core : 7.x
PHP : 5.2
Status : enabled
Path : sites/all/modules/contrib/openid_provider
Schema : module has no schema
version
Files : openid_provider.inc, openid_provider.install,
openid_provider.module, openid_provider.pages.inc
Requires : xrds_simple
Required by : openid_provider_ax, openid_sso_provider,
f_sso_provider, openid_sso_provider_registration,
openid_sso_provider_required_fields,
openid_sso_provider_selection
Permissions : manage own openid sites, administer openid provider
Configure : Keine