Needs review
Project:
OpenID Connect / OAuth client
Version:
3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Jul 2024 at 07:37 UTC
Updated:
12 Mar 2026 at 21:32 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
santhosh@21 commentedComment #5
sarwan_verma commentedHi @santhosh@21,
I have created MR!3 for the above patch, Please review it once.
Comment #6
santhosh@21 commentedHi sarwan_verma
The MR looks good and no issues.
Comment #7
sboto commentedSo is this issue fixed? Is there a way I can configure the redirect uri to use https? The drupal site is dockerized and deployed on azure securely with https already. Where in the code and in which file can I find and configure it?
Comment #8
pfrillingReading through the spec for redirect uri https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest, I'm not sure we should enforce https.
I think the better approach would be to add a new option that allows an administrator to enforce https if they choose.
Comment #10
niels de ruijter commentedMade the enforcement of HTTPS an option like @pfrilling suggested.
Attached is a patch for use in composer patches. (MR diffs can change on any commit).
Comment #11
niels de ruijter commentedComment #12
webflo commentedI saw a similar issue in the OIDC AAD issue queue. #3124961: Enforce HTTPS
I think adding HTTPS at this link is just a cover up for badly configured reverse proxy settings. Described in https://www.drupal.org/project/openid_connect_windows_aad/issues/3124961...