Support AX extensions + namespace collision bug [#1033292]

Better AX shortname construction is needed, using only last URI path isn't working for some parameters e.g. http://axschema.org/contact/phone/home or http://axschema.org/contact/city/home (they both will get short name "home").

Additionally "http://axschema.org/" check prevents any AX extension to use the openid_ax_client hook, so I removed it in the patch.

I attached also screenshot of my example request, which was generated using this patch. I know, dvm() will be better, but I made it this way, so...

Comment	File	Size	Author
#6	1033292-6-openid_client_ax-ax_extensions.patch	3.53 KB	xamanu
#5	ax_extensions_avoiding_namespace_collision-1033292-5.patch	3.53 KB	xamanu
#2	openid_client_ax_shortname.patch	2.17 KB	wojtha
#1	openid_client_ax_notices.patch	1.37 KB	wojtha
#3	openid_client_ax_notices.patch	1.37 KB	wojtha
	openid_client_ax_shortname.patch	2.17 KB	wojtha
	openid_ax_request.png	102.32 KB	wojtha

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

wojtha CreditAttribution: wojtha commented 20 January 2011 at 15:46

File	Size
openid_client_ax_notices.patch	1.37 KB

~~Fixing three unitialized variable notices.~~

Edit: Aarrg... the patch is reversed. Check below.

Comment #2

wojtha CreditAttribution: wojtha commented 20 January 2011 at 15:47

File	Size
openid_client_ax_shortname.patch	2.17 KB

Fixing three unitialized variable notices. (Once more and better...)

Edit: Wrong patch ...

Comment #3

wojtha CreditAttribution: wojtha commented 20 January 2011 at 15:46

File	Size
openid_client_ax_notices.patch	1.37 KB

Oh man, I need more sleep... so now: Fixing three unitialized variable notices.

Comment #4

wojtha CreditAttribution: wojtha commented 9 February 2011 at 10:53

Title:

Support AX extensions

» Support AX extensions + namespace collision bug

#1055838: Namespace collision with short ax identifiers marked as duplicate of this issue.

It includes patch which doesn't introduce new function. However I prefer "my version" of the fix - the explicit name builder function, as it could be used in dependent modules or in other places of the module.

+ Changing the title to be more descriptive.

Comment #5

xamanu CreditAttribution: xamanu commented 4 May 2011 at 02:55

Version:

6.x-1.0-beta2

» 6.x-6.x-dev

File	Size
ax_extensions_avoiding_namespace_collision-1033292-5.patch	3.53 KB

I just put your changes from both patches into one single patch. This might be easier for the module's maintainer to commit. Further I rerolled the patch based on the patch from #501702: Support update_url AX method to update profile data comment #7 since those had conflicts and support of update_url is way older and IMO really necessary.

Comment #6

xamanu CreditAttribution: xamanu commented 4 May 2011 at 03:23

File	Size
1033292-6-openid_client_ax-ax_extensions.patch	3.53 KB

With git diff it made some a/ and b/ directories on the files. Git apply works with this, but it's not working with drush make. So here is a new patch that should apply nicely.