Hello! First all congrats on the project. Seems very organized

Problem/Motivation

I can see on on openchurch_core.module that there is a declaration use in the line 8
 and another one in line 26

Proposed resolution

I think we can move both to the same block in the beginning of file to be grouped

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 Screenshot Before.png134.38 KBrinku jacob 13
#4 Screenshot After.png123.23 KBrinku jacob 13

Issue fork openchurch_core-3336297

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

RenatoG created an issue. See original summary.

RenatoG opened merge request !4

renatog’s picture

renatog commented
Status: Active » Needs review

Implemented the fix on this MR: https://git.drupalcode.org/project/openchurch_core/-/merge_requests/4

rinku jacob 13’s picture

rinku jacob 13 commented
StatusFileSize
new Screenshot After.png123.23 KB
new Screenshot Before.png134.38 KB

Applied the last merge request on drupal latest version. After applying the merge request i can see both declaration on the beginning of the file.
Adding screenshots for the reference. Need +1RTBC

renatog’s picture

renatog commented
Status: Needs review » Reviewed & tested by the community

Based on comment #4, I'm moving that to RTBC

  • RenatoG authored f7d63b11 on 3.0.x 
    Issue #3336297: Two declaration "use" in two different places
drupalninja99’s picture

drupalninja99 commented

Merged, ya'll are killing it!

renatog’s picture

renatog commented

Thank you @drupalninja99

Since was merged, could you closed the ticket as "fixed", please?

It'll automatically disappear from "open tickets" in the issue queue

drupalninja99’s picture

drupalninja99 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.