Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I would like to ask if the following patches can be committed to OpenAtrium for the next release:
#2918907: Section field loses choices after AJAX action
#2827046: Error in Javascript for oa_core's space_type/section_type functionality
#2919684: Prevent infinite loop in oa_toolbar for circularly referenced groups
#2916799: notices in oa_basetheme_preprocess_panelizer_view_mode (from #2454051: Reset of panelizer view mode classes array breaks contextual / quickedit etc.)
#2916708: Update fasttoggle to 1.7
#2916036: Status of bootstrap_library dependency
#2851330: Unable to allow non-adminstrator permissions to create group?!?
#2884977: Translation of ctools modal title
These patches are all working fine on our website.
There are other patches in the queue but I haven't tested those on our website.
Some patches for other modules would also be greatly appreciated:
#2823799: Multiline variables have leading spaces added to each line
#2919686: Prevent infinite loop for circularly referenced groups
#1986532: Support organic groups OG reference widget
#2250177: Improve performance of og_is_group()
#2717489: Infinite loop with og_context() (patch 17)
I hope other developers of OpenAtrium sites can add some suggestions here as well.
Comments
Comment #2
mpotter CreditAttribution: mpotter at Phase2 commentedGot some of these in 2.6.19. Updating title for next future release.
Comment #3
mpotter CreditAttribution: mpotter at Phase2 commentedComment #4
joseph.olstadduring install, lots of missing theme warnings.
could we also get in this patch:
#2844716-5: "Missing/moved modules" PHP warnings should be PHP notices instead
Comment #5
joseph.olstadalso, we should use this patch, drastically speeds up installation time.
#997918-29: Menu gets rebuilt continually during install and update (and menu system stores entire, out-of-date theme objects)
update views to latest dev, lots of performance improvements, fixes, regression fixes for 3.18. 3.19 is expected to be tagged soon.
Comment #6
mpotter CreditAttribution: mpotter at Phase2 commented@joseph not sure about the missing theme warnings. Open a new issue for that, but as it says in that issue you linked I'd rather fix whatever is causing the warnings rather than just ignoring the error.
Also, in this issue, please only link to issues in the actual Open Atrium issue queue. This is a meta-ticket showing issues in the queue that should be applied to the next release. If you have a patch in core or other module that you want, create an atrium issue for it along with the appropriate patch to our make files and then also report any testing, performance improvements, etc. Also, Atrium comes with a "Quick Install" process and we recommend that over normal installs, so improving normal install time is a very low priority.
Finally, remember that many modules in Atrium come via Panopoly (views, etc) and we try not to add additional patches unless they are actually needed for Atrium functionality. We also don't usually use "dev" versions of major modules such as Views. But those patches etc should be reported for Panopoly rather than Atrium.