The oa_files app uses the method oa_related_get_best_section() from the oa_related module, however it does not depend on it in the oa_files.info file.

CommentFileSizeAuthor
#2 2890226-oa_files-dependency-2.patch350 bytesJorrit
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jorrit created an issue. See original summary.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented
FileSize
2890226-oa_files-dependency-2.patch350 bytes

The patch.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented
Status: Active » Needs review
mpotter’s picture

mpotter CreditAttribution: mpotter at Phase2 commented
Status: Needs review » Needs work

Actually, I think that oa_related_get_best_section() function should be moved into oa_core.utils or something. That function isn't specific to oa_related and we don't want oa_files to actually depend on oa_related.

mpotter’s picture

mpotter CreditAttribution: mpotter at Phase2 commented
Status: Needs work » Fixed

Since this spanned across a couple modules, I went ahead and committed the following:

  • oa_core 892f85c (moved the oa_related_get_best_section() to oa_sections_get_best_section() in the oa_sections submodule)
  • oa_related c31a2fb (removed oa_related_get_best_section() and updated function calls)
  • oa_related e74be1f (restored oa_related_get_best_section() to call oa_sections_get_best_section() for backwards compatibility)
  • oa_files 86a84cc (updated function calls)

Didn't want to post a bunch of separate patches, but let me know if those take care of the problem.

Jorrit’s picture

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented

This seems to me to be the best long term solution, thanks a lot!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.