Problem/Motivation

Drupal version: 10
use the module as usual and the following warning appears

Deprecated function: Creation of dynamic property Drupal\open_readspeaker\Plugin\Block\OpenReadspeakerBlock::$request is deprecated en Drupal\open_readspeaker\Plugin\Block\OpenReadspeakerBlock->__construct() (línea 53 de /var/www/html/web/modules/contrib/open_readspeaker/src/Plugin/Block/OpenReadspeakerBlock.php)

CommentFileSizeAuthor
#2 open_readspeaker-3413732.patch3.21 KBsaesa

Issue fork open_readspeaker-3413732

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

saesa created an issue. See original summary.

saesa’s picture

saesa commented
StatusFileSize
new open_readspeaker-3413732.patch3.21 KB

This patch work for me!

saesa’s picture

saesa commented
Status: Active » Needs review
cbccharlie’s picture

cbccharlie commented

Hi @saesa, this seems duplicate of #3384235: deprecation dynamic property. Could you please review it. Thanks!

saesa’s picture

saesa commented

Why doesn't the maintainer release a version 2.x release?

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented

Because of #3399535: Rework config keys.

wylbur’s picture

wylbur commented
Status: Needs review » Reviewed & tested by the community

Just confirming that the patch in #2 resolves php errors for our install:

drupal 10.3.1
php 8.2
open_readspeaker 1.10.0

Marking this as RTBC.

Also confirming that is the active ticket for the 1.x branch of the module - which is the recommended version at this time.

acbramley made their first commit to this issue’s fork.

acbramley’s picture

acbramley commented
Version: 8.x-1.10 » 8.x-1.x-dev

Opened MR with gitlab CI file, hiding patches.

acbramley opened merge request !31

sunlix closed merge request !31

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Status: Reviewed & tested by the community » Fixed

I have Cherry-Picked from #3384235: deprecation dynamic property.
@cbccharlie was totally right, it's kind of a duplicate of 3384235. The solution does apply to 1.x Branch also.

For the GitLab CI there will be a dedicated issue. This is out of scope of this issue.

acbramley’s picture

acbramley commented

Ok thanks @sunlix, can you please release a new version on 1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented

@acbramley

do you still need a new 1.x release? Or are you fine for migrating to 2.x?
It should be a smooth migration if there a no real customizations.