Improve the naming of the older config key.
We want to remove the unnecessary open_readspeaker prefixes to make the config keys more clear.

open_readspeaker.settings

  • open_readspeaker_i18n => lang
  • open_readspeaker_voice => voice
  • open_readspeaker_accountid => customer_id
  • open_readspeaker_url => webreader_url
  • open_readspeaker_cdn_region => cdn_region

block.settings.open_readspeaker_block

  • button_url (new)
  • open_readspeaker_buttonstyle (removed)
  • open_readspeaker_buttontext => button_text
  • open_readspeaker_buttontitle => button_title
  • open_readspeaker_reading_area => reading_area
  • open_readspeaker_reading_area_class => reading_area_class

lang, voice, customer_id are used to make the query parameters in the current template.

Issue fork open_readspeaker-3399535

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sunlix created an issue. See original summary.

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Issue summary: View changes

sunlix opened merge request !35

sunlix’s picture

sunlix
Primary language English
Location Wesel
commented

  • sunlix committed 9714c872 on 2.x 
    Issue #3399535 by sunlix: Rework config keys
sunlix’s picture

sunlix
Primary language English
Location Wesel
commented
Status: Active » Fixed

I am good with the state of the config schema.
This is merged to 2.x. I will release a alpha-verison to test that out.

Currently there is no migration path for the Block-Plugin changes (replaced with another plugin ID)
That will be a follow up on the road to stable.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.