Problem/Motivation

Readspeaker only comes in one voice. We can change voices by just adding voice param to url.

Proposed resolution

Add voice parameter to url.

Remaining tasks

Finalize the approach and fix it.

User interface changes

User can configure different voices.

API changes

A new voice parameter is added to the url.

CommentFileSizeAuthor
#2 add_voice_parameter-2467225-2.patch1.75 KBjibran
add-voice.patch1.71 KBjibran

Comments

killua99’s picture

killua99 commented
Status: Needs review » Needs work 
  1. +++ b/open_readspeaker.module
@@ -153,6 +153,7 @@ function theme_open_readspeaker_ui() {
+  $open_readspeaker_voice = variable_get('open_readspeaker_voice', '');

    Where is use this variable? 

  2. +++ b/open_readspeaker.module
@@ -184,7 +185,7 @@ function theme_open_readspeaker_ui() {
-  $output .= '<a class="rsbtn_play" title="' . t('Listen to this page using ReadSpeaker') . '" accesskey="L" href="' . $http . '://app.eu.readspeaker.com/cgi-bin/rsent?customerid=' . $accountid . '&amp;lang=' . $open_readspeaker_i18n . '&amp;readid=' . variable_get('open_readspeaker_reading_area', 'rs_read_this') . '&amp;url=' . urlencode($request_path) . '">';

    I must be blind. What changes here?

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new add_voice_parameter-2467225-2.patch1.75 KB

I must be blind. What changes here?

Self review failed. I was checking the interdiff to verify the changes and I updated the diff in that process :D

killua99’s picture

killua99 commented
Status: Needs review » Needs work

How I can setup the voice reader? command line?

Need UI