It would be nice if the list of services provided by on_the_web_get_services() was alterable by other modules.

CommentFileSizeAuthor
#4 alter-services-4.patch604 bytesc31ck
#1 alter-services-1.patch758 bytesc31ck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

c31ck’s picture

c31ck CreditAttribution: c31ck commented
Status: Active » Needs review
FileSize
alter-services-1.patch758 bytes

Patch that lets other modules change the list of services. This is off course not an ideal solution, but it gives other modules a chance to quickly re-order the services and/or remove some of them.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Assigned: Unassigned » jenlampton
Status: Needs review » Fixed

This looks like a very elegant solution, actually. :)

I couldn't get your patch to apply to the dev branch, but I did exactly the same thing, and attributed the commit to you. This feature should be in the next release.

Thanks for this!

c31ck’s picture

c31ck CreditAttribution: c31ck commented

Thanks for the commit attribution and the quick response :)

c31ck’s picture

c31ck CreditAttribution: c31ck commented
Status: Fixed » Needs review
FileSize
alter-services-4.patch604 bytes

I think you forgot a piece of code in http://drupalcode.org/project/on_the_web.git/commitdiff/0c6ecfaac8bce53b.... The array is returned before the drupal_alter is called.

Attached you'll find a patch against 7.x HEAD that should apply.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Assigned: jenlampton » c31ck
Status: Needs review » Reviewed & tested by the community

Please go ahead and commit to 7.x, and can you check 6.x to make sure we still have feature parody?

c31ck’s picture

c31ck CreditAttribution: c31ck commented
Status: Reviewed & tested by the community » Fixed

Fixed in c1f32f73daf0cb350d5c08588bd65721e14e1f96.

c31ck’s picture

c31ck CreditAttribution: c31ck commented
Version: 7.x-1.2 » 6.x-1.2
Assigned: c31ck » Unassigned
Status: Fixed » Patch (to be ported)

Setting status for backport to 6.x.

jenlampton’s picture

jenlampton
she / her
CreditAttribution: jenlampton commented
Status: Patch (to be ported) » Fixed

Same change applied to D6 branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.