Error if menu module is disabled [#1866116]

Comment	File	Size	Author
#3	omniture-check_if_menu_is_enabled-1866116-3.patch	834 bytes	lucascaro

	omniture-add_menu_dependency.patch	625 bytes	lucascaro

Comment #1

bleen CreditAttribution: bleen commented 13 December 2012 at 20:46

Nice catch ... one thought though. Is it preferable to add this dependency or to add a if(module_exists('menu')){...} to the token context code?

Log in or register to post comments

Comment #2

lucascaro CreditAttribution: lucascaro commented 13 December 2012 at 21:06

good point. module_exists makes sense, that way we can still provide contexts for nodes and taxonomies if menu is not enabled... I can post another patch if it helps.

Log in or register to post comments

Comment #3

lucascaro CreditAttribution: lucascaro commented 13 December 2012 at 21:12

File	Size
omniture-check_if_menu_is_enabled-1866116-3.patch	834 bytes

this one should do

Log in or register to post comments

Comment #4

bleen CreditAttribution: bleen commented 24 December 2012 at 02:39

Status:

Needs review

» Needs work

what about all the token tree form elements like this:

$form['advanced']['tokens'] = array(
    '#theme' => 'token_tree',
    '#token_types' => array('node', 'menu', 'term', 'user'),
    '#global_types' => TRUE,
    '#click_insert' => TRUE,
  );

Maybe we need a function to abstract "token type" as well?

Log in or register to post comments

Comment #5

lucascaro CreditAttribution: lucascaro commented 11 January 2013 at 17:59

Status:

Needs work

» Needs review

@bleen18 that is showing the available tokens and if the menu module is not enabled it will not show tokens for menus, so that shouldn't be a problem.

That's the only other reference to the menu module in omniture so the patch should work as it is (unless it's too old, so I'll re-test it just in case :D )