I have found out that whenever a view is set to have a full or mini pager with a setting of 0 Items per page (no limit) then undefined index notices appear on omega.theme.inc that have to do with lines 214, 222, 251 for the mini pager and lines 39, 62 for the full pager. Actually the mini pager displays this error on line 214 whatever the items per page setting.

For a full pager setting the view to display all items or a very big number is a solution but for a mini pager at least line 214 of omega.theme.incneeds to be ammended so as not to be found undefined.

Notice: Trying to access array offset on value of type null in omega_pager() (line 39 of /home/kwbirds/public_html/sites/all/themes/omega/omega/includes/omega.theme.inc).
Notice: Trying to access array offset on value of type null in omega_pager() (line 62 of /home/kwbirds/public_html/sites/all/themes/omega/omega/includes/omega.theme.inc).

Notice: Undefined index: quantity in omega_views_mini_pager() (line 214 of /home/kwbirds/public_html/sites/all/themes/omega/omega/includes/omega.theme.inc).
Notice: Trying to access array offset on value of type null in omega_views_mini_pager() (line 222 of /home/kwbirds/public_html/sites/all/themes/omega/omega/includes/omega.theme.inc).
Notice: Trying to access array offset on value of type null in omega_views_mini_pager() (line 251 of /home/kwbirds/public_html/sites/all/themes/omega/omega/includes/omega.theme.inc).

CommentFileSizeAuthor
#4 interdiff-3166808-2-4.txt728 bytesfenstrat
#4 3166808-4.patch2.13 KBfenstrat
#2 3166808-1.patch1.7 KBarx-e

Comments

arx-e created an issue. See original summary.

arx-e’s picture

arx-e commented
Status: Active » Needs review
StatusFileSize
new 3166808-1.patch1.7 KB

I made this patch against the latest dev (2 lines in the mini pager section have already been removed by a previous patch as they were not used) and it works for me both with min and full pagers in PHP 7.4.

johnpitcairn’s picture

johnpitcairn commented
Version: 7.x-3.1 » 7.x-3.x-dev
Status: Needs review » Reviewed & tested by the community

Patch applies with composer against latest dev for me, appears to fix the problem. Let's call it RTBC.

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
StatusFileSize
new 3166808-4.patch2.13 KB
new interdiff-3166808-2-4.txt728 bytes

This LGTM.

Attached adds one more case where I was seeing Trying to access array offset on value of type null in omega_pager(). Leaving as RTBC.