Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I just did a quick review of this theme for accessibility. Noticed that there was a lot of text hidden by CSS display:none; and no way to gain focus on the regions without a keyboard.
adding focus to the hover here should help:
alpha/css/alpha-debug.css
Comment | File | Size | Author |
---|---|---|---|
#6 | omega-do-not-remove-outline-for-accessibility-reasons-1503102-5.patch | 344 bytes | sylvain_a |
Comments
Comment #1
marcoka CreditAttribution: marcoka commentedComment #2
dboudreau CreditAttribution: dboudreau commentedTwo quick CSS fixes that could be added here would be:
I'm happy to help with both today.
Comment #3
sylvain_a CreditAttribution: sylvain_a commentedI've been working with Denis today and i'll be able to do a follow-up on it.
(Ideally a patch, or at least the exact CSS code suggested.)
Comment #4
sylvain_a CreditAttribution: sylvain_a commentedIndeed, an outline is needed on focusable elements for accessibility reasons.
It seems that the actual behaviour could be traced back to the use of Eric Meyer's "reset.css", with its recognizable "remember to define focus styles" comment. A quick and precise rationale is available here:
http://www.outlinenone.com/
This could be corrected by replacing this part in "alpha/alpha-reset.css":
with
Comment #5
sylvain_a CreditAttribution: sylvain_a commentedAlternatively, on the long term, using normalize.css could be an option, to replace the original reset.css.
Here is what normalize.css offers as best practices for outlines, after thorough experimentation:
Comment #6
sylvain_a CreditAttribution: sylvain_a commentedAs a themer, I'm not really familiar with patches, but here is what a patch could look like. Please review (using branch 7.x-3,x).
Comment #7
mgiffordThanks sylvain!
Comment #8
Cellar Door CreditAttribution: Cellar Door commentedSeems reasonable to me... himerus what do you think of this for a 3.2 inclusion?
Comment #9
Cellar Door CreditAttribution: Cellar Door commentedJust saw on the 3.2 roadmap. I'll put it as ready to be patched since it's a one liner that won't crash anything
Comment #10
DamienMcKennaI believe "Needs review" is the correct status, given someone uploaded a patch.
Comment #11
mgiffordAgreed! And it still applies in SimplyTest.me even though it is 3 years old.