Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Title says it all, patch in the first comment.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | omega-panels-classes-1253046-2.patch | 7.15 KB | jwilson3 |
| #1 | omega-panels-classes-1253046.patch | 4.05 KB | jwilson3 |
Comments
Comment #1
jwilson3Comment #2
jwilson3Actually the problem is slightly more complex. If you render, for example, a mini-panel that uses a grid layout as a block using contexts... then a lot of layout settings are off -- What I originally noticed was that rows of grids that add up to 12 do not actually fit onto one line, because the first and last box in the row don't properly collapse their left and right margins respectively (using the alpha/omega classes). I've now also discovered that the grid-12 class itself applied to a panel-pane that are supposed to expand to full width, also exhibit a similar problem... have too much margin. Instead of adding alpha AND omega classes to the grid-12 panel-panes, to collapse their left and right margins, i just opted to remove the grid-12 altogether.
In this updated patch I've:
1) removed all the grid-12 classes, because they appear to be unnecessary to explain that a column should fill the full width.
2) added some additional alpha and omega classes that I missed in #1.
Comment #3
fubhy CreditAttribution: fubhy commentedI am aware of this, however the plan is that those alpha/omega classes become unnecessary at some point. @see #1245428: panels layouts break column alignment
I don't want all the nesting with regions and panels as we have it currently (and thus requiring those alpha/omega classes on the top-level). I will update this issue after DCon (where we will discuss the future of Omega and Panels thoroughly)
Comment #4
jwilson3I bet this same issues exist for the grid-16 and grid-24 layouts that I haven't had a chance to test or look at, but I hesitate to mark this as 'needs work' myself until a maintainer has a chance to look at this and at least confirm that my fixes are on the right track... as I'm no grid expert, i may be way off the mark here ;P
Comment #5
jwilson3oops, we commented at the same time, and my comment changed the status back... Lets mark this as a duplicate, instead of postponed, and take the conversation over to #1245428: panels layouts break column alignment.