Currencies sent to Ogone have decimals [#2064443]

Hi!

When the amount is sent to Ogone it contains 2 decimals.
Ogone fails to process and gives the following error:
amount too long or not numeric: length 6 MAX:15

E.g. for 100 euro: 100,00 is sent, but it should be 10000

Problem is located in the redirectData function where amount is rounded.

function redirectData(Payment $payment) {
    ....
    $data = array(
      'AMOUNT' => currency_load($payment->currency_code)->roundAmount($payment->totalAmount(TRUE)),
      'PSPID' => $payment->method->controller_data['pspid'],
...
}

In the development version before issue 1955396 the amount was multiplied by 100.
The following change should also work for currencies with more than 2 decimals!

 ...
$currency = currency_load($payment->currency_code);    
$data = array(
   'AMOUNT' => $currency->roundAmount($payment->totalAmount(TRUE)) / $currency->getRoundingStep(),
...

Hope this helps! :)

Comment	File	Size	Author
#11	8145887-10-adding_scale_to_bcmul.patch	800 bytes	Anonymous (not verified)
#11
#5	ogone_2064443_5.patch	856 bytes	Xano
#5
#3	2064443-2-currencies-sent-to-ogone-have-decimals.patch	844 bytes	askibinski
#3
#1	2064443-1-currencies-sent-to-ogone-have-decimals.patch	902 bytes	askibinski
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

askibinski CreditAttribution: askibinski commented 21 August 2013 at 13:20

Priority:	Normal	» Major
Status:	Active	» Needs review

File	Size
2064443-1-currencies-sent-to-ogone-have-decimals.patch	902 bytes

Here is a patch with above code.

I stumbled upon this myself today. Kinda major because ogone does not accept any payments now otherwise.

Comment #2

21 August 2013 at 13:28

Status:

Needs review

» Needs work

The last submitted patch, 2064443-1-currencies-sent-to-ogone-have-decimals.patch, failed testing.

File	Size
2064443-2-currencies-sent-to-ogone-have-decimals.patch	844 bytes

Comment #4

askibinski CreditAttribution: askibinski commented 21 August 2013 at 14:16

Status:

Needs work

» Needs review

status change...

Comment #5

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 30 August 2013 at 08:36

File	Size
ogone_2064443_5.patch	856 bytes

+++ b/ogone/includes/OgonePaymentMethodController.inc
@@ -484,8 +484,9 @@ class OgonePaymentMethodController extends PaymentMethodController {
+      'AMOUNT' => $currency->roundAmount($payment->totalAmount(TRUE)) / $currency->getRoundingStep(),

This is a float division. Seeing as we use Currency anyway, we might as well use BC Math for this too. Also, the rounding step is configurable and as such cannot be used to 'move the comma'.

The patch uses the calculated number of decimals to find out how much to 'move the comma' and uses BC Math to perform the actual calculation.

Comment #6

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 14 September 2013 at 09:10

Bump. Can someone review the patch?

Comment #7

Anonymous (not verified) CreditAttribution: Anonymous commented 24 September 2013 at 14:42

Status:

Needs review

» Reviewed & tested by the community

Did the job for me

Comment #8

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 24 September 2013 at 14:50

Status:

Reviewed & tested by the community

» Fixed

Thanks for your help!

Comment #9

8 October 2013 at 14:51

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #10

Anonymous (not verified) CreditAttribution: Anonymous commented 5 November 2013 at 14:44

Issue summary:	View changes
Status:	Closed (fixed)	» Needs review

hmm, apparently i'havent tested thoroughly, i've still got the decimals.. scaling the bcmul should do the job

Comment #11

Anonymous (not verified) CreditAttribution: Anonymous commented 5 November 2013 at 14:47

File	Size
8145887-10-adding_scale_to_bcmul.patch	800 bytes

Comment #12

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 5 November 2013 at 16:03

Status:

Needs review

» Needs work

This is not a fix to the original problem. Provided the currency is configured correctly, $currency->roundAmount() should make sure there are not too many decimals, and the bcmul() with pow() should simply move the comma.

Can you make sure the number of subunits is correctly set for the currency you are using and can you paste the expected and actual values here?