CommentFileSizeAuthor
#3 2921249-3.patch474 bytesgeertvd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geertvd created an issue. See original summary.

geertvd’s picture

OgMenuInstance sets the language property to configurable which causes a dependency on the language module, when to language module is not enabled I get the following error:

Schema errors for core.entity_form_display.ogmenu_instance.n3RWEeib.default with the following errors: core.entity_form_display.ogmenu_instance.n3RWEeib.default:content.langcode.settings.include_locked missing schema
geertvd’s picture

FileSize
474 bytes

Removing setDisplayConfigurable('form', TRUE) from the base field definition fixes it for me.
I language_entity_base_field_info_alter() would take care of setting that to TRUE anyway if language module is enabled.

geertvd’s picture

Status: Active » Needs review
pfrenssen’s picture

This makes sense, it is also consistent with how the language field is defined in ContentEntityBase::baseFieldDefinitions().

I'll check if the patch still applies and still fixes the failure in the current HEAD. If this succeeds this is good to go for me.

  • pfrenssen committed 8636cad on 8.x-1.x authored by geertvd
    Issue #2921249 by geertvd: Failing test due to missing content.langcode....
pfrenssen’s picture

Status: Needs review » Fixed

The patch still applies and the failure is fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.