Problem/Motivation

Add OG module attributes alternatives. Convert all usages of OgDeleteOrphans, OgFields and OgGroupResolver annotations into attributes.

CommentFileSizeAuthor
#5 3511201.diff20.96 KByaqbick
#2 3511201.diff21.04 KByaqbick

Issue fork og-3511201

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yaqbick created an issue. See original summary.

yaqbick’s picture

yaqbick commented
StatusFileSize
new 3511201.diff21.04 KB
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: yaqbick » Unassigned
Status: Active » Needs work

@yaqbick Could you make this a merge request please? Also before you do that can you have a peek at the work done here: #3503767: Support Drupal >=10.3. Modernize the code

alorenc made their first commit to this issue’s fork.

yaqbick’s picture

yaqbick commented
StatusFileSize
new 3511201.diff20.96 KB

yaqbick opened merge request !31

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Postponed (maintainer needs more info)

This really looks like a duplicate of what is in #3503767: Support Drupal >=10.3. Modernize the code, am I miss reading or should it be closed as a duplicate?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Postponed (maintainer needs more info) » Needs review

This really looks like a duplicate...

That's true but I would go with this to lower the footprint of the other.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Fixed

This is straight refactoring. And looks OK. Merged

PS: I will adapt the other MR

alorenc’s picture

alorenc
Location Wolsztyn, 🇵🇱
commented

I can see a potential issue here: OG 8.x-1.x can be installed on D9, but attributes were added in D10.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

You're right. I will revert the merge and issue a new release In #3503767: Support Drupal >=10.3. Modernize the code we will only support >=10.3 and that will go in 2.x. Let's keep the work there

  • claudiu.cristea committed 5330dd80 on 8.x-1.x 
    Revert "Issue #3511201 by yaqbick, alorenc, joelpittet, claudiu.cristea...
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Fixed » Closed (won't fix)

This was reverted and released 1.0.0-alpha12