Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
When unsubscribing from a group, the submit button text is 'Remove'.
This makes the string untranslatable. as all instances of 'Remove' will then be translated.
We still want te be able to remove some items from the site, not unsubscribe them!
Proposed resolution
Replace 'Remove' on the unsubscribe confirm form with 'Unsubscribe' in line with the call-to-action button.
Remaining tasks
- Write a patch
- Review
- Commit
User interface changes
When unsubscribing from a group, the submit button text on the confirm form is 'Unsubscribe' instead of 'Remove'.
API changes
None.
Data model changes
None.
Comment | File | Size | Author |
---|---|---|---|
#4 | og-unsubscribe_confirm_text-2831715-4.patch | 1.68 KB | idebr |
|
Comments
Comment #2
idebr CreditAttribution: idebr at One Shoe commentedAttached patch updated the text on the confirm form submit button from 'Remove' to 'Unsubscribe'.
Comment #4
idebr CreditAttribution: idebr at One Shoe commentedThis updated patch also updates the test with the new button text.
Comment #5
Johan den Hollander CreditAttribution: Johan den Hollander at Finalist commentedComment #6
Johan den Hollander CreditAttribution: Johan den Hollander at Finalist commentedWe used this patch with 7.x-2.9.
It's valid and meaningful.
Comment #7
Johan den Hollander CreditAttribution: Johan den Hollander at Finalist commentedComment #8
alesr CreditAttribution: alesr at BigScreen Group commentedComment #9
amitaibu@alesr, thanks - please commit to d.o (and push to GitHub as-well). Oh, yes - you have commit access to do that now! :)
Comment #11
alesr CreditAttribution: alesr at BigScreen Group commented