Problem/Motivation

When unsubscribing from a group, the submit button text is 'Remove'.
This makes the string untranslatable. as all instances of 'Remove' will then be translated.
We still want te be able to remove some items from the site, not unsubscribe them!

Proposed resolution

Replace 'Remove' on the unsubscribe confirm form with 'Unsubscribe' in line with the call-to-action button.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

When unsubscribing from a group, the submit button text on the confirm form is 'Unsubscribe' instead of 'Remove'.

API changes

None.

Data model changes

None.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

idebr created an issue. See original summary.

idebr’s picture

Status: Active » Needs review
FileSize
1023 bytes

Attached patch updated the text on the confirm form submit button from 'Remove' to 'Unsubscribe'.

Status: Needs review » Needs work

The last submitted patch, 2: og-unsubscribe_confirm_text-2831715-2.patch, failed testing.

idebr’s picture

Status: Needs work » Needs review
FileSize
1.68 KB

This updated patch also updates the test with the new button text.

Johan den Hollander’s picture

Issue summary: View changes
Johan den Hollander’s picture

We used this patch with 7.x-2.9.
It's valid and meaningful.

Johan den Hollander’s picture

Status: Needs review » Reviewed & tested by the community
alesr’s picture

Issue tags: +OG-7.x-2.10-release
amitaibu’s picture

@alesr, thanks - please commit to d.o (and push to GitHub as-well). Oh, yes - you have commit access to do that now! :)

  • alesr committed 2377e42 on 7.x-2.x authored by idebr
    #2831715 Unsubscribe confirm firm uses 'Remove' as button text.
    
alesr’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.