Problem/Motivation

Noticed while saving on the user's group reference field (like found in og_example) that OgMembershipCrud would send people to OG_STATE_PENDING. Which doesn't make sense for the administer users who have access to that field.

Proposed resolution

Allow 'administer group' permission access to OG_ACTIVE_STATE

CommentFileSizeAuthor
#2 allow_administer-2770927-2.patch1.04 KBjoelpittet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joelpittet created an issue. See original summary.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Active » Needs review
FileSize
allow_administer-2770927-2.patch1.04 KB

Here's a patch that adjusts the conditions for the administer group permission.

Status: Needs review » Needs work

The last submitted patch, 2: allow_administer-2770927-2.patch, failed testing.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Needs work » Needs review

The OgFieldWidgetTestCase fails are kinda strange.
The OgAccessTestCase::testMemberShipRequestStatus failure is because the drupal user 1 which has administer group permissions I believe.

Status: Needs review » Needs work

The last submitted patch, 2: allow_administer-2770927-2.patch, failed testing. View results

alesr’s picture

alesr CreditAttribution: alesr at BigScreen Group commented
Status: Needs work » Active

@joelpittet - @AronNovak tackled with this in https://github.com/Gizra/og/pull/255/commits/1b32b2c7d60f6245bf85e35091f... and OgBehaviorHandler was rewritten so this patch doesn't apply any more.

Does the original issue still persist?

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Active » Postponed

thanks @alesr, I'll have to try this out. I'll let you know.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet as a volunteer commented
Status: Postponed » Closed (duplicate)

Thanks @alesr, I believe that did fix it, I'm removing the patch from production.