The documentation says that the function og_get_groups_by_user() returns: "An array with the group IDs or an empty array."

When user doesn't have any membership, the function don't return an empty array.

CommentFileSizeAuthor
#7 og-og-fix_return_value_of_og_get_groups_by_user-2569471-7.patch1.34 KBjacob.embree
#3 og-fix_return_value_of_og_get_groups_by_user-2569471-3.patch718 bytesrobertom
#2 og-fix_return_value_of_og_get_groups_by_user-2569471-1.patch445 bytesrobertom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

robertom created an issue. See original summary.

robertom’s picture

robertom CreditAttribution: robertom commented
Status: Active » Needs review
FileSize
og-fix_return_value_of_og_get_groups_by_user-2569471-1.patch445 bytes
robertom’s picture

robertom CreditAttribution: robertom commented
FileSize
og-fix_return_value_of_og_get_groups_by_user-2569471-3.patch718 bytes

New version for fix another "return;"

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
CreditAttribution: mxr576 at Pronovix commented
Status: Needs review » Reviewed & tested by the community

I found the same issue and this patch looks a proper solution to me. I'd say it should be added to OG as soon as possible after 11 months inactivity.

David Hernández’s picture

David Hernández CreditAttribution: David Hernández as a volunteer commented

I didn't notice this issue and I've created a duplicated one on github. Linked it here to give proper credit.

Issue on github, just in case: https://github.com/Gizra/og/issues/152

David Hernández’s picture

David Hernández CreditAttribution: David Hernández as a volunteer commented

By the way, I can confirm that this patch still applies nicely.

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
FileSize
og-og-fix_return_value_of_og_get_groups_by_user-2569471-7.patch1.34 KB

Fixing the return value renders the check for the return type unnecessary in OgSelectionHandler.class.php.

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented

Actually, David, would you care to add a commit to your pull request that removes that line? According to the project page for this module development takes place on GitHub.

jacob.embree’s picture

jacob.embree CreditAttribution: jacob.embree at St. Louis Integration commented

The GitHub issue for this is here: og_get_groups_by_user not working as documented #152.
Here is one pull request: Fixes issue 152. Replaces NULL returns with emtpy array returns in og_get_groups_by_user #153
Here is my pull request: Fixes #152: Replaces NULL returns with emtpy array returns in og_get_groups_by_user() #359

alesr’s picture

alesr CreditAttribution: alesr at BigScreen Group commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +OG-7.x-2.10-release

Reviewed changes and accepted PR is here: https://github.com/Gizra/og/pull/359#pullrequestreview-111661199 to speed things up.

alesr’s picture

alesr CreditAttribution: alesr at BigScreen Group commented

Hiding patches in this issue to keep the consistency of active development on GitHub.

  • jacob.embree committed 28c2d66 on 7.x-2.x 
    Issue #2569471 by robertom, jacob.embree: og_get_groups_by_user don't...
alesr’s picture

alesr CreditAttribution: alesr at BigScreen Group commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.