Rules integration bug - user added twice to same group

The issue is triggered because Rules calls user_save() after the "User has become a group member" rule has been executed, and this results in og_group() being called a second time during page load.

This shouldn't be an issue, but og_get_membership() uses a static cache to keep track of which entities are in which groups and this isn't cleared after a change in group membership.

The attached patch clears the og static caches whenever a change takes place to the membership information using the existing insert/update/delete hooks.

Bumping to Major priority as rules integration is a very common use-case and this causes both group administration and content duplication issues (appearing duplicated in og/commons Views), especially with Drupal Commons.

The previous patch was too generic when clearing the static cache, which seems to cause an issue with the UIF module.

This patch clears only the specific static cache entries.

I'm seeing the exact same problem as the original poster, even with the patch in comment 4 applied. It seems that after the "User has been removed from group" rule fires, og_og_membership_insert() is still being called and re-adding the user membership.

-mike

I'm trying to use Rules to add or remove a value on a user entity (the user entity of the og membership entity) when the user is added or removed from a group. Regardless of whether I use the "User has been removed from group" or "After deleting a og membership" trigger, like ultimike, even after applying the patch in #4, I'm seeing that the og membership gets restored (og membership ID is incremented).

I decided to try this outside of Rules: implement hook_og_membership_insert and hook_og_membership_delete in a module and update or clear the field I was targeting in my rules. Interestingly, I had the same result: I couldn't get the insert to work via the OG admin interface, but manually updating the user to add the group worked, setting my field to the correct value, and then attempting to remove the user from the group began exhibiting the same behavior: the user remained in the group, but the og_membership id got incremented (aka old membership deleted and then restored). So this behavior seems independent of the Rules module.

I see this is related to #2148047 issue.

Any update on this issue?

The problem still exists in 7.x-2.10. I tried patch #4, but it doesn't solve the problem.

I can confirm hackwater's finding: this problem is actually completely independent from rules.

Even if using hook_og_membership_delete() in a custom module. As soon as anything does user_save (could be directly, could be via user_multiple_role_edit), then the membership gets created again immediately after deletion.

This really seems to be a major bug in the module's logic. I suspect, it has something to do with the membership field (og_group_ref), but I can't provide a solution.

OK, there are several bug reports addressing the base problem.

I wonder, if there's actually an issue, where possible work could be brought together.
None of these threads seems to be very active.

I have same problem with 7.x-2.10.
When group node is deleted, the author will stay member of the group even it is deleted (user stays in the og_membership table).

In my case the problem comes only when group node is deleted by site administrator and a role is added or removed to the node:author using a rule.
Problem does not exists if the group node is deleted by the author, the author will not appear back to the og_membership table.

So maybe it's something related to (user save) when it's done by admin...

Tried also with the latest dev version but same problem.