Cannot set organic groups Groups Audience field on an entity with a "name" key [#1880226]

I have both Organic Groups (og) and Bean enabled on a test site. I would like to be able to assign bean blocks to groups. I am able to add the Groups Audience field (provided by og) to my block type. However, if I create or edit a block and try to set the Groups Audience field, I get the following error:

EntityMetadataWrapperException: Invalid data value given. Be sure it matches the required data type and format. in EntityDrupalWrapper->set() (line 744 of .../sites/all/modules/contrib/entity/includes/entity.wrapper.inc).

If I leave the groups audience field set to "none", I am able to save the block.

Comment	File	Size	Author
#5	og-use_numeric_id_for_membership_etid-1880226-5.patch	1.7 KB	Chris Burge
#5
#4	og-use_numeric_id_for_membership_etid-1880226-4.patch	2.31 KB	cecrs
#4
#3	og-use_numeric_id_for_membership_etid-1880226-3.patch	2.22 KB	acrollet
#3
#2	og-use_numeric_id_for_membership_etid-1880226-2.patch	1.45 KB	acrollet
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

indytechcook CreditAttribution: indytechcook commented 21 January 2013 at 14:54

Status:

Active

» Postponed (maintainer needs more info)

Hey Paul,

The latest release contains some fixes to the Entity Metadata which might fix some of these issues. Can you please test?

Comment #2

acrollet CreditAttribution: acrollet commented 8 March 2013 at 21:34

Title:	Cannot set organic groups Groups Audience field in a bean block	» Cannot set organic groups Groups Audience field on an entity with a "name" key
Project:	Bean (for Drupal 7)	» Organic groups
Version:	7.x-1.0-rc7	» 7.x-2.x-dev
Component:	Code	» og.module
Status:	Postponed (maintainer needs more info)	» Needs review

File	Size
og-use_numeric_id_for_membership_etid-1880226-2.patch	1.45 KB

I had this problem, as described by OP. What I found is that the audience field assumes that it will get a numeric identifier. (See the schema for the etid column on the og_membership table). However, EntityMetadataWrapper's getIdentifier method returns the field specified by the 'name' entity key, if present. I modified the og code to always get the id, as opposed to the machine name. Patch attached, although it's probably more a starting point for discussion than a committable patch, given that getIdentifier() is used in several other places. That being said, this patch does allow one to save a new bean entity with an attached group audience field, and did not affect the ability to save a new node with a group audience field.

Comment #3

acrollet CreditAttribution: acrollet commented 8 March 2013 at 22:11

File	Size
og-use_numeric_id_for_membership_etid-1880226-3.patch	2.22 KB

updated patch attached - this also modifies the load method of the OgBehaviorHandler class, allowing the selected audience to be seen when viewing a bean.

Comment #4

cecrs CreditAttribution: cecrs commented 9 August 2013 at 19:56

File	Size
og-use_numeric_id_for_membership_etid-1880226-4.patch	2.31 KB

Re-rolled against the latest dev.

Comment #5

Chris Burge CreditAttribution: Chris Burge commented 22 October 2014 at 16:42

Issue summary:

View changes

File	Size
og-use_numeric_id_for_membership_etid-1880226-5.patch	1.7 KB

Re-rolled patch against the latest dev.

The 'includes/og.membership.inc' file has been reworked since the last patch was posted on this issue, and its respective hunk no longer applies. This hunk has been removed from this patch. The code in question was modified by #2231217: Prevent loading entity in \OgMembership::save() upon og_group(), which also employs the 'entity_load_single' function.

My testing indicates the patch continues to work as designed.