Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The "Primary" and "Secondary" fields are a bad concept, and it's reflected in the amount of code needed for it.
Work is undergoing in branch 1730678
to replace it with a "complex" widget.
Node edit:
Field settings -- Remove all the confusing config, in favor of just selecting the widget types:
Comment | File | Size | Author |
---|---|---|---|
#15 | Selection_056.png | 5.45 KB | jhedstrom |
#12 | 1730678-og-complex-widget-10.patch | 69.45 KB | amitaibu |
#6 | 1730678-complex-widget-6.patch | 69.98 KB | amitaibu |
Groups audience | Site-Install.jpg | 29.33 KB | amitaibu | |
Edit Post test | Site-Install.jpg | 17.99 KB | amitaibu |
Comments
Comment #0.0
amitaibuUpdated issue summary.
Comment #1
amitaibuAnyone around to help me with upgrading the tests? :)
Comment #2
JohnnyX CreditAttribution: JohnnyX commentedIs it available in latest dev?
Comment #3
amitaibuComment #4
JohnnyX CreditAttribution: JohnnyX commentedI tested another way to build a nice widget to set content to one or more groups....
Autocomplete Deluxe module! Works fine! Also with tag style! So groups can added and removed a nice way to content.
What is missing is a widget to add other users a simple and nice way to one or more (own) groups ;)
Comment #4.0
JohnnyX CreditAttribution: JohnnyX commentedUpdated issue summary.
Comment #5
azinck CreditAttribution: azinck commentedIs this just waiting on your patch being committed to ctools, or are there still specific problems with the new widget that need work?
Thanks for this. It's very exciting; should make things much better!
Comment #6
amitaibuPatch for make file
Comment #7
jhedstromTesting out the patch in #6, one bit of feedback is that this is still confusing for administrators when there is an entityreference prepopulate widget in play, since this fails to populate the new widget if the administer is not part of the group.
Comment #8
jhedstromAlso, unless I've misconfigured my widget, I'm getting ajax errors due to this code in
og_entityreference_autocomplete_callback()
always returning access denied (throwing a browser error since this isn't returned as json) for groups the administrator is not a member of.Comment #9
amitaibuI believe you, but I can't reproduce. It's seems to work fine with ER_prepopulate.
Comment #10
amitaibuOh, I understand now what you mean about #8, I'll look into it.
Comment #11
amitaibuActually I don't, re-checked, and works ok ;)
Comment #12
amitaibuAnd here's the patch for testbot.
btw, no longer depends on #1707810: Allow mockup field settings in ctools_field_invoke_field()
Comment #12.0
amitaibuUpdated issue summary.
Comment #13
amitaibuand ... committed!
Comment #14
jhedstromWhen trying to edit *any* og content, an exception is thrown since
$other_groups_ids
is always false, thus$valid_ids
is always empty.Comment #15
jhedstromAlso, if I comment out the call to the set() method from #14 to bypass the unhandled exception, when editing, both the 'Default' and the 'Administrator' values are filled in:
resulting in this error when saving:
This also happens on node creation when using the entityreference prepopulate widget as an administrator.
Comment #16
amitaibu@jhedstrom,
Can you please open a new issue for this, but just to answer
> an exception is thrown since $other_groups_ids is always false
That's not right, if I'm a a user that doesn't belong to *all* groups, then $other_group_ids is populated.
Comment #17
azinck CreditAttribution: azinck commentedI've filed a new issue against jhedstrom's problem from #15: #1781674: For new Complex Widget, Entityreference Prepopulate populates both Default AND Administrator values
Comment #18.0
(not verified) CreditAttribution: commentedUpdated issue summary.