Current Status Feature

So this is an actual implementation of #696262: Show Status 'Open/Closed (now/today/soon)' in Views ?
The feature is also mentioned as a 'current status block' in #1539768: Merge 'Simple Hours' Sandbox module with 'Office hours'?

I could not test, only apply and review code.

+++ b/office_hours.elements.inc
@@ -71,6 +71,11 @@ function _office_hours_select_process($element, &$form_state, $form) {
   if (is_numeric($element['#default_hours'])) {
     list($defhr, $defmin, $ampm) = _office_hours_return_defaults($element['#default_hours'], $element['#hoursformat']); 
   }
+  else {
+    $defhr = 0;
+    $defmin = '';
+    $ampm = 'am';
+  }

- There is a difference in $defhr between your code and the initialization in _office_hours_return_defaults(). Is this intentional? (we could commit this separately.)
- You better move this part into _office_hours_return_defaults(), and change it to:

@@ -71,6 +71,11 @@ function _office_hours_select_process($element, &$form_state, $form) {
-   if (is_numeric($element['#default_hours'])) {
-     list($defhr, $defmin, $ampm) = _office_hours_return_defaults($element['#default_hours'], $element['#hoursformat']); 
+   list($defhr, $defmin, $ampm) = _office_hours_return_defaults($element['#default_hours'], $element['#hoursformat']); 
-   }

  if ($timezone)
    $currentDT->setTimezone(new DateTimeZone($timezone));

- Please use {} after the if-statement;

 function _office_hours_field_formatter_defaults($settings = array()) {
-  return array_merge(array(
+  return array_replace_recursive(array(
     'daysformat' => 'long',

- This is an introduction of a PHP5.3 function. Please find a PHP5.2 alternative. I could do no further tests because of this.

OK, this applies nicely.
Couldn't find the new feature, though.
Can you post instructions how to use it?

OK, I'll try

This looks promising, but I would create a separate formatter for it, for the following reasons:
-- this feature deserves a better, more prominent place. A proper formatter gives an initial choice to the user;
-- the code can be more isolated; the current patch is very big, and it took me a while to apply it manually. Isolation separates this feature from your work on refacturing the formatter.
-- the current version does not allow to NOT show the opening times. (I can imagine separate blocks: 1 with regular opening times, 1 with more prominent OPEN NOW!)

I mean creating a second formatter 'Office hours - current status', next to the default 'Office hours' one.
This second formatter would have its own callback-function where 'Current status' is formatted.
The settings can be either in 2 forms, or hidden, depending on the choice of formatter.

That's not difficult:
1. in office_hours.module

function office_hours_field_info() {
   68   return array(
   69     'office_hours' => array(
   ...
   75      ),
+  69     'office_hours_status' => array(
+  ...
+  75      ),
   76   );
   77 }

2. in office_hours.theme.inc

 function office_hours_field_formatter_view($entity_type, $entity, $field, $instance, $langcode, $items, $display) {
  12   $element = array();
  13   if ($items) {
+ switch $display['type']:
+         case 'office_hours':
  14     $element[0] = array('#markup' => theme($field['type'] . '_formatter_default',
+          case 'office_hours_status':
  14     $element[0] = array('#markup' => theme($field['type'] . '_formatter_status',
  19   }
  20   return $element;
  21 }

3. now implement function theme_office_hours_formatter_status($vars)

See Field Formatter API for more details.

I don't think you can show the same field twice on a node-view-page, that's true.
You can add the same field twice in Views. And you can add blocks with different data on the same page.

Your suggestion #19 looks fine. Can you roll a patch against latest version?

can't wait for this feature - subscribe!

This sounds good!

I would like to ask about this feature, because its very important for my project.
Will it be implemented til the end of year? Maybe is it possible to support somehow?

thank you!

@adelka, do you know some php? You can help by adapting patch from #8, and post a fresh patch. Then I'll try and get it in.

@ juhnv, I know basic of php - principles, function etc. But unfortunately I dont feel I can handle so difficult task. :(
Can I help by testing or anything else?

I have applied the prefious patches to durrent dev-version. Please test it.
Only did some minimal testing.

I'd like to add an option to ONLY show the Current status, not only before/after.

I've tested it on last dev version 7.x-1.x-dev.

Worked great, I tried also display current status in views!

Just few notes =>

1. I had following errors:

Notice: Undefined index: #bundle v office_hours_field_formatter_settings_form() (riadok 193 z /data/d/a/darcekpodlateba.sk/web/sites/all/modules/office_hours/office_hours.module).
Notice: Undefined index: #entity_type v office_hours_field_formatter_settings_form() (riadok 193 z /data/d/a/darcekpodlateba.sk/web/sites/all/modules/office_hours/office_hours.module).

both caused by views.

2. it would by great to show only current status by views (right now I can hide only day notation). Of course, text can be hidden byt CSS.
3. amazing feature can be filter of current status - so I can for example expose the filter and show only opened entities.

Great job! THANK YOU!

This is added in commit 18770b9 .

You can add the Current status before, after, of instead of the hours listings.
There is no support for other timezones, yet.
There is no support for selecting currently open/closed locations in a Views selection box.

Thanks to Lazarus-Long for the initial patch.

Loving this feature in the dev module, but I'm wondering.. Would it also make sense to include the current day's time below the open/close message if you use the 'hiding hours' position?

With some token support? 'Open in x hours' is a much wanted feature too.

To add some more ideas, I think CSS class for opened/closed status can be great, so I we can format for example opened div to green and closed div to red color.

Will be there new release for 7th verzion, so we can just updade module?

@adelka, check out latest dev for new css-classes. I'll create a new version the coming weeks.
@jackfoust, what do you mean? Just showing the time, like a clock? Only when it is closed, or also when opened?

I was wondering about the opening-soon feature: if the location is closed, you could display 'opening in 3 hours'. But it would be even better to show a 'closing in 3 hours' message, to persuade people to come NOW, TODAY to your store, library, restaurant.

@johnv, I was thinking of something along the lines of the following. I have taxonomy branches with office hours attached.

Branch A
Currently Open!
Tuesday 8:00 AM - 10:00 PM

Branch B
Currently Closed!
Tuesday 8:00 AM - 10:30 AM

Just to be sure, I've understood well - "There is no support for selecting currently open/closed locations in a Views selection box." means that it's not possible because views module doesn't allow that?
sorry, if its stupid question...

@adleka, to be able to show currently open locations, this module must provide the correct data to Views.
patches are welcome.

I did a rework of this, integrating the current_status feature better with the hours format.
@jackfoust, there is also a 1-line format, too.

Regarding Views filter: I did a quick (and dirty) workaround using jQuery, reading the status from the display formatter. Of course this method only makes sense when all items are displayed on one page. But it does the trick for me, for now.

JS:

jQuery(document).ready(function($) {
	$('#filter-open').click(function(e) {
                            // Replace .views-col with the according most outer container of the view item
		$(".oh-current-closed").parentsUntil(".views-col").css("display", "none");
	});
$('#filter-all').click(function(e) {
	$(".oh-current-closed").parentsUntil(".views-col").css("display", "block");
});

});

HTML:

<button id="filter-open">Currently open</button>
<button id="filter-all">Show all</button>

I would love to see a proper Views filter "Open / Closed", though. I can do quite some PHP but I don't really know where to start here. Hints are welcome!

@dsjena, this sounds nice. Can you re-post this in a new issue? Thanx.

I've installed update, nice feature.

Unfotunatelly, It's not working correctly when opening hours are set to:
1./ 0:00-0:00 - I expected something like opened nonstop
2./ 20:00-6:00 - opened also after midnight - show closed for example when it's 21:00
3./ 8:00-0:00 - show closed for example when it's 21:00. When I changed 0:00 to 23:45, status "currently open" was shown correctly.

@patriktakac, nice catch.
ad 1. This is not implemented yet. See #1661512: Open all day (From 00 hrs to 24 hrs) (D7)
ad 2/3. can you open a follow-up issue?