There is no definition of OAuthSignatureMethod which means if I did new OAuthSignatureMethod_HMAC('SHA1'); I get an error because that class extends OAuthSignatureMethod, which is not defined in the autoloader hook.

I've not included this as a patch as its a 1 line fix...

CommentFileSizeAuthor
#2 899506.patch844 bytesezra-g
#1 899506.patch717 bytesezra-g
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ezra-g’s picture

FileSize
717 bytes

Here's a patch that implements this change.

I ran into this working on #404470: Authenticate Twitter_Actions.module via OAuth.module 2.x instead of Basic Auth.

ezra-g’s picture

FileSize
844 bytes

Here's a more correct patch that implements this change as part of oauth_common_autoload_info().

greggles’s picture

The fact that this is needed for #404470: Authenticate Twitter_Actions.module via OAuth.module 2.x instead of Basic Auth means that lots of folks are going to want this fixed in short order since there are 15,000 users of the twitter.module who need it.

Also, subscribing ;)

voxpelli’s picture

All implementations yet has already had that class loaded when they needed to use it due to it being in the same file as a lot of other OAuth classes, so might be that something is a bit odd with the current implementation that #404470: Authenticate Twitter_Actions.module via OAuth.module 2.x instead of Basic Auth is working on.

I'll try to keep track of that issue and I will fix this issue the next time I do commits for the OAuth module.

voxpelli’s picture

To clarify: This is not needed for #404470: Authenticate Twitter_Actions.module via OAuth.module 2.x instead of Basic Auth as that issue is about fixing the current support for OAuth 2.x and not to implement new support for OAuth 3.x.

Artusamak’s picture

Status: Needs review » Reviewed & tested by the community

Little up on the subject, is it planned to add this patch soon? It's definitely needed. ;)
Thanks.

voxpelli’s picture

It will be in the next release

voxpelli’s picture

Status: Reviewed & tested by the community » Fixed

This has been commited and will appear very soon in 6.x-3.0-beta3 - thanks for the patch and help!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.