I get a "cron run successfully" below the following stack trace. My notifications remain queued.

Warning: in_array() expects parameter 2 to be array, null given in _notify_send() (line 743 of modules/notify/notify.module).
_notify_send() (Line: 63)
notify_cron()
call_user_func_array('notify_cron', Array) (Line: 391)
Drupal\Core\Extension\ModuleHandler->invoke('notify', 'cron') (Line: 223)
Drupal\Core\Cron->invokeCronHandlers() (Line: 122)

CommentFileSizeAuthor
#6 2946151-6.patch542 bytesoriol_e9g
#4 2946151-4.patch1.17 KBoriol_e9g
#3 2946151.patch593 bytesoriol_e9g
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rnhunt created an issue. See original summary.

rnhunt’s picture

rnhunt CreditAttribution: rnhunt as a volunteer commented

OK, so I finally got around to have a look and found the bug. Not set up to patch or commit to git yet (not a trusted bug reporter even) but the change is simple enough,

if (NULL !== ($config->get('notify_skip_comments'))) {
$notify_skip_comments = array();
} else {

should of course be

if (NULL == ($config->get('notify_skip_comments'))) {
$notify_skip_comments = array();
} else {

Line 712 in notify.module.

Items still queued and yet to be sent though.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Active » Needs review
FileSize
2946151.patch593 bytes
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
FileSize
2946151-4.patch1.17 KB

There are the same bug in nodes. Correct fix with the coding standards way.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Needs review » Needs work

Needs reroll for #2958084: Coding standards

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g at Diputació de Barcelona commented
Status: Needs work » Needs review
FileSize
2946151-6.patch542 bytes

  • ilchovuchkov committed 75011d5 on 8.x-1.x 
    Issue #2946151 by ilchovuchkov, oriol_e9g: null given in _notify_send().
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Needs review » Reviewed & tested by the community

Re-roll the patch and committed to 8.x-1.x dev branch. Thank you!

vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at Bulpros Consulting commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.