The notify module refers out to drupal_html_to_text(); however this is not part of the Drupal 8.x API and causes an exception which is visible if turn on fault tracking.

CommentFileSizeAuthor
#2 drupal_html_to_text_missing-2945752-2.patch1003 bytesmalaynayak
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rnhunt created an issue. See original summary.

malaynayak’s picture

malaynayak CreditAttribution: malaynayak as a volunteer and at TA Digital commented
Status: Active » Needs review
FileSize
drupal_html_to_text_missing-2945752-2.patch1003 bytes

Hi,

drupal_html_to_text() is no longer there is drupal8. Drupal\Core\Mail\MailFormatHelper::htmlToText() should be used instead.

I have made the changes accordingly. Please review the patch.

rnhunt’s picture

rnhunt CreditAttribution: rnhunt commented

Thanks for that, quick! Yes, it fixes the issue. I still have other issues however - will raise separately. Appreciate the work for this important module.

malaynayak’s picture

malaynayak CreditAttribution: malaynayak as a volunteer and at TA Digital commented

Hi @rnhunt,

Thank you for the appreciation. Could you please give me some credit for the patch.

Thanks

rnhunt’s picture

rnhunt CreditAttribution: rnhunt as a volunteer commented

Sure, I'm new to this though so you will need to let me know how!

malaynayak’s picture

malaynayak CreditAttribution: malaynayak as a volunteer and at TA Digital commented

@rnhunt,

Please refer the links:

1. https://www.drupal.org/getting-involved/maintainer/grant-issue-credits

Also, you can commit the patch by using the same command from credits and committing section below.

rnhunt’s picture

rnhunt CreditAttribution: rnhunt as a volunteer commented
rnhunt’s picture

rnhunt CreditAttribution: rnhunt as a volunteer commented
Status: Needs review » Reviewed & tested by the community

All fine in my testing.

  • gisle committed b2fa0de on 8.x-1.x authored by malaynayak 
    Issue #2945752 by malaynayak: Fixed drupal_html_to_text() missing
gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Committed to the 8.x-1-x development branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.