Hey there,

So all my content links are like:
1. My Title
[
http://default/blog/url-to-content
]

My site URL is not http://default.

I'm digging around. I had fixed this with a sort of hackish string replace, forgot, then updated. Maybe I can do something more serious.

peace
jj

Comments

glass.dimly’s picture

This is apparently common for functions being run in cron when the $base_url is not set in settings.php: http://stackoverflow.com/questions/3993997/how-to-get-drupals-base-url-t...

On line 1453 of notify.module it's calling the url() function to make the link, so the failing is the url() function being run in the context of cron without $base_url being set.

I have now set it, and we'll see if that fixes things. I have to wait until my next post to see.

If it does work, I'd say that this would be important to add to the README.

Peace
Jeremy

gisle’s picture

Status: Active » Postponed (maintainer needs more info)

Have you had the chance to test if setting $base_url correctly fixing this?

If "yes", what to you suggest is added to the README?

If I understand the issue correctly, this bug (if it is a bug) is not located in Notify, but is how the core url() function works. Notify cannot override the standard behaviour of a core function.

gisle’s picture

Component: Code » Documentation
Category: Bug report » Task

I don't think this is a bug in Notify. Changing category and component.

glass.dimly’s picture

Priority: Normal » Major
Status: Postponed (maintainer needs more info) » Active

Agreed, not a bug. Rather, since it is a necessary configuration step for many normally configured drupal sites, it is part of the installation of the module. Because it can render the module unusable (giving wrong inbound links in notifications) I have marked it as "Major."

I think the following should be added to the readme:

"In order to properly render links from emails to your site, it is often necessary to set the $base_url in your settings.php file. Examples for how to do this are provided in settings.php. If you do not, your inbound links may be rendered as http://default."

  • gisle committed c35e7b8 on 7.x-1.x
    #2357555 by gisle: Added notes about troubleshooting http://default in...
gisle’s picture

Version: 7.x-1.1 » 7.x-1.x-dev
Assigned: Unassigned » gisle
Priority: Major » Normal
Status: Active » Reviewed & tested by the community

Text explaining how to troubleshoot this problem has been added to the Notify online documentation and the README.txt of the 7.x-1.x development branch. It will be included in the next regular release.

gisle’s picture

Status: Reviewed & tested by the community » Fixed

This is fixed in release 7.x-1.3.

gisle’s picture

Version: 7.x-1.x-dev » 7.x-1.3

Forgot to set version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.