Closed (fixed)
Project:
Meta tags Node Type
Version:
5.x-1.1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Aug 2008 at 03:48 UTC
Updated:
24 Jun 2009 at 05:30 UTC
Jump to comment: Most recent file
Comments
Comment #1
john bickar commentedSubscribing.
I'll take a look at this module and see if I can offer a patch.
Comment #2
john bickar commentedPatch attached which shamelessly lifts code from the nodewords and nodewords_nodetype modules :)
Comment #3
hanoiiA bit late, but committed and thanks.
Comment #4
avpadernoThe patch uses a private function of Meta tags, which is not necessary kept between an official version and the successive.
Comment #5
hanoiiComment #6
hanoiiIt's not the patch itself that's using the private but rather the module. Patch is fine.
Private function issue @ #483286: The code uses a private Meta tags function
Comment #7
avpadernoThe patch code calls
_nodewords_check_content()in the following code lines:Comment #8
avpadernoComment #9
hanoiiI know, but it just copies what I do on other lines of the code. I am accepting the patch because although the private function is there, it's as well on the original module. It makes no sense continuing the discussion here while we are talking about it in the other issue. And besides, the patch was already committed and released on the new version of the module.