Exception on the page with reviews for node [#1287464]

When I open page with reviews (node/%nid/reviews) I get the following exception:

Notice: Undefined property: stdClass::$reviews in nodereview_view() (line 315 of sites/all/modules/nodereview/nodereview_node_nodereview.inc).
Warning: array_keys() expects parameter 1 to be array, null given in nodereview_view() (line 315 of sites/all/modules/nodereview/nodereview_node_nodereview.inc).
Notice: Undefined property: stdClass::$op in nodereview_view() (line 320 of nodereview/nodereview_node_nodereview.inc).
Notice: Undefined property: stdClass::$nid in node_build_content() (line 1359 of modules/node/node.module).
EntityMalformedException: Missing bundle property on entity of type node. in entity_extract_ids() (line 7389 of includes/common.inc).

Comment	File	Size	Author
#8	nodereview_d7_port.patch	85.31 KB	euginewm

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

danielhonrade CreditAttribution: danielhonrade commented 23 September 2011 at 02:48

yeah, it's still buggy and non-function, hope someone will help on this...

Comment #2

yaworsk CreditAttribution: yaworsk commented 23 September 2011 at 03:13

sorry, been out of the loop. I'll try and take a look this weekend and see if I can help out in any way...

pete

Comment #3

euginewm CreditAttribution: euginewm commented 23 September 2011 at 06:30

it seems that hook_load not implemented, so in nodereview_view property $review for node doesn't exist

Comment #4

euginewm CreditAttribution: euginewm commented 26 September 2011 at 10:00

I'm almost all done:
Implementation of hook_permision
Implementation of hook_install in accordance with the standards of Drupal 7
Hook_load and hook_view are fixed.
Some problems associated with discrepancies transmitted data types in connection with porting to Drupal 7 have been solved

How can I upload my code?

Comment #5

danielhonrade CreditAttribution: danielhonrade commented 23 September 2011 at 22:43

HI,

can you make a diff? and just attach here.

thanks.

Comment #6

euginewm CreditAttribution: euginewm commented 26 September 2011 at 09:58

now I'm finishing with the module, there are some bugs that need to be fixed.
I have made a lot of improvements, many changes were performed.
I'm very interesting in maintaining this module, could you please add me as co-maintainer of this module?

Comment #7

danielhonrade CreditAttribution: danielhonrade commented 26 September 2011 at 12:09

Sure, why not, please post your work and we'll have it reviewed, thanks

Comment #8

euginewm CreditAttribution: euginewm commented 28 September 2011 at 14:55

File	Size
nodereview_d7_port.patch	85.31 KB

Hi all
I have rewrote almost the whole module, I have tested it as much as I can.
Please, review it and test if you can.
Needs to write tests and implement token API. I can do that after you will review attached patch.
I hope you will add me as co-maintainer.

Thanks, Eugene

Comment #9

danielhonrade CreditAttribution: danielhonrade commented 28 September 2011 at 15:48

Hey great work, I just committed your patch, will be available later.

Comment #10

danielhonrade CreditAttribution: danielhonrade commented 28 September 2011 at 15:52

ok, I just added you as maintainer, please just maintain the category to Voting and not on its own category, don't include also the license, the instructions on git commits/download are all there.

Happy to have you, and move this project forward, thanks

Comment #11

danielhonrade CreditAttribution: danielhonrade commented 28 September 2011 at 23:41

Hi Eugine,

Some of the things I noticed:

Review content type
- should not be included in the list of content types for review, /admin/config/nodereview, because it cannot review itself
- should not also be listed in front page, it's not a regular node, you can check the D6 version of nodereview and follow how it behaves

daniel