Support for latest JQuery (1.4.2) and JQuery UI (1.8.5) [#942518]

I would be nice to have support for the latest JQuery. Many modules make use of JQuery. It's a pitty that this module 'noderelationships' restricts jquery to version 1.3.x and 1.7.x.

Comment	File	Size	Author
#2	942518-fix_noderelationships_jquery-2.patch	3.22 KB	travist

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

markus_petrux CreditAttribution: markus_petrux commented 16 October 2010 at 09:58

Status:

Active

» Postponed (maintainer needs more info)

As of yet there is no official/stable method to make Drupal work with jQuery 1.4. That is why there is no official support for new jQuery stuff here. Related issue to follow: #685060: Get ready for 1.4

We could review patches here, if there's anything that needs adjustements to make this module work with JQuery 1.4.x and JQuery UI 1.8.x... anyone tried this combination of libraries?

Comment #2

travist CreditAttribution: travist commented 12 December 2011 at 20:00

Status:

Postponed (maintainer needs more info)

» Needs review

File	Size
942518-fix_noderelationships_jquery-2.patch	3.22 KB

We just upgraded to jQuery and noticed that this module does in fact break, but most of the problems that I found thus far are just the references to className as an attribute within jQuery, such as the following code.

var className = $element.attr('className');

Newer versions of jQuery does not fall back to reference the DOM object, but will simply ignore these. Instead, it expects "class" for the attribute name like so.

var className = $element.attr('class');

The result is that the + buttons do not show up on the controls, which from what I can tell is the only thing broken with upgraded jQuery.
The fix here is to use attr('class') instead of className on the jQuery object.

The following patch should fix at least this part of the issue.

Thanks,

Travis.