Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hello
Thanks for creating this module - its been very useful.
I noticed some issues on a dev site that uses revisions. The way the code is now, if your nid value of a node is different to the vid then you will encounter problems, perhaps with the count being assigned to a different node altogether.
I will be adding a patch here.
Comment | File | Size | Author |
---|---|---|---|
#1 | nodereference_count_736846_vid.patch | 1.83 KB | smoothify |
Comments
Comment #1
smoothify CreditAttribution: smoothify commentedHere is the patch....
Comment #2
gilgabar CreditAttribution: gilgabar commentedThanks. I hadn't had time to handle revisions correctly, so the patch is much appreciated. I'll review as soon as I get a little time. Thanks again.
Comment #3
gilgabar CreditAttribution: gilgabar commentedPatch looks good. Committed to HEAD and should be available in a dev release shortly.
I'm curious about the optional vid argument on nodereference_count_update_count() added. It doesn't appear to be used. Is there an intended use or is it just there in case it becomes useful? I have no objections to including it. Just curious if you have something in particular in mind.