I see you have the variables:

  • nodejs_socket_io_path
  • nodejs_socket_io_type

that are not really being used currently.

Patch to use external socket.io.js client files like:
https://cdn.socket.io/socket.io-1.1.0.js

Settings configured on /admin/config/nodejs/config

Socket.io config settings

CommentFileSizeAuthor
#2 socket-io-settings.png37.37 KBmonstrfolk
#2 external-socket.io_.js-option-2389917-2.patch2.31 KBmonstrfolk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

I would be interested in seeing what you've come up with.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
FileSize
external-socket.io_.js-option-2389917-2.patch2.31 KB
socket-io-settings.png37.37 KB

Patch to allow configuration for external socket.io client for minified js. Good for SEO.

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Issue summary: View changes
monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Version: 7.x-1.9 » 7.x-1.x-dev
Component: User interface » Code
Category: Task » Feature request
Status: Active » Needs review
monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented
Title: Use of nodejs_socket_io_path and nodejs_socket_io_type for external socket.io.js client files » Configurable option for external minified socket.io.js client from CDN
SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

I just came across this. More of an FYI:

https://github.com/socketio/socket.io/issues/1847

And that issue mentioned this cdn for socket.io:
https://cdn.socket.io/socket.io-1.2.0.js

List of CDNs:
https://cdnjs.com/libraries/socket.io

Are there others?

monstrfolk’s picture

monstrfolk CreditAttribution: monstrfolk commented

The minified option is gone from socket.io 1 and above.

  • beejeebus committed 30e263e on 7.x-1.x authored by monstrfolk 
    Issue #2389917 by monstrfolk: Configurable option for external minified...
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

thanks! pushed to 7.x.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Active

changing to D8.