nodejs screws up panels in place editing: this.ipeReplacedBeforeSerialize is not a function

Clearly this doesn't happen to everyone. You need to show how others can reproduce the problem.

i can confirm this issue. since i've installed nodejs IPE stopped working.

Hi,

I assume the conflicting code in panels_ipe is the following in panels_ipe/js/panels_ipe.js?

 Drupal.ajax.prototype.ipeReplacedBeforeSerialize = Drupal.ajax.prototype.beforeSerialize;
Drupal.ajax.prototype.beforeSerialize = function (element_settings, options) {
if ($(this.element).attr('id') == 'panels-ipe-save') {
Drupal.PanelsIPE.editors[this.element_settings.ipe_cache_key].saveEditing();
};
return this.ipeReplacedBeforeSerialize(element_settings, options);
}; 

Based upon javascript console results:
panels_ipe's Drupal.ajax.prototype.ipeReplacedBeforeSerialize references the original ajax function first (before the nodejs.js override).
Then nodejs.js's Drupal.Nodejs.originalBeforeSerialize references the already over-written Drupal.ajax.prototype.beforeSerialize, before over-writing it once again with its own code that happens to reference the over-written fake original from panels_ipe that contained this.ipeReplacedBeforeSerialize.

Should panels_ipe.js simply be returning Drupal.ajax.prototype.ipeReplacedBeforeSerialize(element_settings, options) instead?

Cheers

That's a shame. I'm using Panel 7.x-3.3 as part of some old Panopoly distro. Admittedly, I haven't tried saving anything (and I'm afraid to try - since I don't use IPE anyway) but the error has disappeared in my case and the customize and change layout buttons appear to work normally.

  Drupal.ajax.prototype.ipeReplacedBeforeSerialize = Drupal.ajax.prototype.beforeSerialize;
  Drupal.ajax.prototype.beforeSerialize = function (element_settings, options) {
    if ($(this.element).attr('id') == 'panels-ipe-save') {
      Drupal.PanelsIPE.editors[this.element_settings.ipe_cache_key].saveEditing();
    };
    return Drupal.ajax.prototype.ipeReplacedBeforeSerialize(element_settings, options);
  };

});

I've just come across this same issue. I tried updating as per #13 and while this fixed the issue which prevented the panels dialog from opening there still remains a problem where updating or adding panels does not save so I am re-opening the ticket.

The issue is caused because the scope of "this" is changed by the Nodejs implementation of beforeSerialize, when Drupal.Nodejs.originalBeforeSerialize is called the scope of "this" is changed from the Drupal.ajax object to the Drupal.Nodejs object. This results in the panels_ipe saveEditing function not getting called.

To fix this I assigned the originalBeforeSerialize function to the Drupal.ajax prototype and then call it with "this" within the overridden beforeSerialize function, this is the same technique that is used by panels_ipe.js. This way the scope is maintained and the panels can be saved. Also this does not require the change in #13 to the panels_ipe.js.

Importantly, this would also potentially fix any interoperability issues with this module and any others that override the Drupal.ajax.beforeSerialize function. Here is the code I updated...

      Drupal.ajax.prototype.nodejsOriginalBeforeSerialize = Drupal.ajax.prototype.beforeSerialize;
      Drupal.ajax.prototype.beforeSerialize = function(element_settings, options) {
        options.data['nodejs_client_socket_id'] = Drupal.Nodejs.socket.socket.sessionid;
        return this.nodejsOriginalBeforeSerialize(element_settings, options);
      };

The on disconnect function needs to be updated with the new name as well (a serious side effect of this bug is that if the node.js server becomes disconnected then Drupal.ajax.prototype.beforeSerialize becomes 'undefined' and all AJAX requests will subsequently fail even after reconnection).

  Drupal.Nodejs.socket.on('disconnect', function() {
    Drupal.Nodejs.runSetupHandlers('disconnect');
    if (Drupal.ajax != undefined) {
      Drupal.ajax.prototype.beforeSerialize = Drupal.Nodejs.originalBeforeSerialize;
    }
  })

;

should be changed to:

  Drupal.Nodejs.socket.on('disconnect', function() {
    Drupal.Nodejs.runSetupHandlers('disconnect');
    if (Drupal.ajax != undefined) {
	Drupal.ajax.prototype.beforeSerialize = Drupal.ajax.prototype.nodejsOriginalBeforeSerialize;
    }
  });

(Convention-wise, should I post the patch to a new thread for a "closed (fixed)" topic?).

P.S. Thanks to Firebug's profiling feature for making my debugging easier...

Cheers. I've attached #23's equivalent in patch.

Hi, issue appears on latest dev version.
Error message: "Cannot read property 'sessionid' of undefined"
Patch attached.