Automated Drupal 10 compatibility fixes

Tests are currently failing with:

Fatal error: Declaration of Drupal\Tests\node_view_permissions\Functional\NodeViewPermissionsTest::setUp() must be compatible with Drupal\Tests\BrowserTestBase::setUp(): void

and

The Drupal\Tests\node_view_permissions\Functional\NodeViewPermissionsTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426

Otherwise, everything checks out. The patch includes the fixes to the test file. Keeping this as "Needs Review." Marking this as RTBC should be pretty straightforward, given that this module doesn't have a lot of PHP code.

I have reviewed and checked Patch #4 this works for drupal 9.4 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.4 and the Permission page on 10 have been attached for reference:

Note: since this module does not have any additional dependencies or requirements, the addition of the `composer.json` file in the MR above is techincally superfluous, if innocuous.

From https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-file :

If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required. However, having a composer.json does not have a negative impact either.

So, in this case, the patch in #4 is still sufficient.

Both #4 and #7 are working fine. The maintainers should decide if they want a composer.json or not.

composer.json is actually important if you wish to include a merge request with composer directly:

{
...
    "repositories": {
        "node_view_permissions": {
            "type": "vcs",
            "url": "https://git.drupalcode.org/issue/node_view_permissions-3288795"
        },
   }
...
    "require": {
        "drupal/node_view_permissions": "dev-3288795-automated-drupal-10"
    }
}

Without it, such installation is impossible.

If #4 and #7 are fine, can we start using this on a D10 site?

Thanks.

~ Subir

Patch #4 is failing for me in Drupal 10.0.7
Giving the below error:

------ ---------------------------------------------------------------------------------------
Line node_view_permissions.module
------ ---------------------------------------------------------------------------------------
65 Call to an undefined method Drupal\Core\Entity\ContentEntityInterface::isPublished().
------ ---------------------------------------------------------------------------------------

[ERROR] Found 1 error

The above issue has been fixed in the new patch attached here.

patch #12 worked fine for me and shows 0 compatible issues in local.

I have tested patch #12 and it is working fine without any errors on Drupal 9 (9.5.7) and on Drupal 10 (10.0.3) in my local.

Moving this to RTBC.

It'd be cool to get a merge of this at least into dev so it can be used in d10 without referencing the mr branch in composer.json.

(Hello)
Same as loopy, it will be really helpful !
(Thks for maintaining btw)

Agreed, looking for clean D10 installable-version, would be very helpful

+1 I'm also looking forward for a tagged Drupal 10 release.

Keen too to see a table D10 release is that's viable.
Thanks for this highly useful module!

Thank you all for your work!

Merge request !2 by @mattjones86 (includes patch #4 by @mark_fullmer and composer.json by @mattjones86) will be accepted.

Patch #12 is not necessary, because without it the module works correctly on Drupal 10.0.7 and higher. @sarathkp please provide the steps to reproduce so that we can check it. You will probably need to create a separate issue for this.