Validation for minimum and maximum characters

CommentFileSizeAuthor
#4 interdiff-2625604-2-4.txt774 bytesharika gujjula
#4 2625604-4.patch1.12 KBharika gujjula
#2 2625604-2.patch1019 bytesharika gujjula
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

harika gujjula created an issue. See original summary.

harika gujjula’s picture

harika gujjula CreditAttribution: harika gujjula at Valuebound commented
Status: Active » Needs review
FileSize
2625604-2.patch1019 bytes

Validation check for minimum and maximum character length to be greater than 0.

krknth’s picture

krknth CreditAttribution: krknth as a volunteer and at Valuebound commented
Status: Needs review » Needs work

Can you combine two conditions ?

if ($max <= 0) {
  form_set_error('max-' . $type->type, t("Value should be greater than 0"));
}

and 

 if ($max > 255) {
     form_set_error('max-' . $type->type, t("These value should be less than 256"));
   }
harika gujjula’s picture

harika gujjula CreditAttribution: harika gujjula at Valuebound commented
Status: Needs work » Needs review
FileSize
2625604-4.patch1.12 KB
interdiff-2625604-2-4.txt774 bytes

Added Patch and Interdiff

krknth’s picture

krknth CreditAttribution: krknth as a volunteer and at Valuebound commented
Status: Needs review » Reviewed & tested by the community

Looks good. Changing min, max labels 'length' to 'characters' will be more reasonable.

  • krknth committed aae1735 on 7.x-1.x authored by harika gujjula 
    Issue #2625604 by harika gujjula, krknth: Validation for minimum and...
krknth’s picture

krknth CreditAttribution: krknth as a volunteer and at Valuebound commented
Status: Reviewed & tested by the community » Fixed

Thanks. changed label too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.