We should convert the module to short array as per new coding standard

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Assigned: Pavan B S » Unassigned
Status: Active » Needs review
FileSize
4.99 KB

Applying the patch, please review

dhruveshdtripathi’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
54.71 KB

Patch applied cleanly. All the arrays converted to short array syntax. Checked it manually. As you can see in the attached png file, earlier there were 17 array declarations, after applying patch there is 1. That 1 array declaration is in_array.

Good work!

  • scott_euser committed aa9bf08 on 8.x-1.x authored by Pavan B S
    Issue #2877887 by Pavan B S, dhruveshdtripathi: Convert module to use...
scott_euser’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +SpringSprintLondon2017

Fixed and committed on dev, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.