The usage of create_function() has been deprecated as of PHP 7.2. It should be replaced with an alternative solution. This module uses it on line 1007 of the main module file.

CommentFileSizeAuthor
#4 node_export-support_php_72-2946171-4.patch1.84 KBoadaeh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bkosborne created an issue. See original summary.

mmjvb’s picture

mmjvb CreditAttribution: mmjvb as a volunteer commented

See #2931464: Features PHP 7.2 Function create_function() is deprecated

oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Assigned: Unassigned » oadaeh

I'm working on this.

oadaeh’s picture

oadaeh CreditAttribution: oadaeh at Hook 42 commented
Assigned: oadaeh » Unassigned
Status: Active » Needs review
FileSize
node_export-support_php_72-2946171-4.patch1.84 KB

Attached is a patch that addresses this issue.
I did not entirely follow the example provided in the similar patch for Features, as that requires specifying a higher PHP version than core specifies.
Also, I could not figure out how to create a situation where the code in question would get triggered, so I could not verify the results were the same. So, I will need someone who knows the module better to verify that.

herved’s picture

herved CreditAttribution: herved commented

+1 The patch looks good to me, thanks.
I tested it by adding $o->reference_test = $o; at the top of node_export_remove_recursion().
It produces the same output as the original.

anmolgoyal74’s picture

anmolgoyal74 CreditAttribution: anmolgoyal74 at OpenSense Labs for DrupalFit commented
Status: Needs review » Reviewed & tested by the community

  • gaurav.kapoor committed ed5ed65 on 7.x-3.x authored by oadaeh 
    Issue #2946171 by oadaeh: PHP 7.2+ future proofing, remove usage of...
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

web226’s picture

web226 CreditAttribution: web226 commented

Thank you, the patch in #4 worked for me on PHP 8.0.28