Automated Drupal 10 compatibility fixes

ModuleHandlerInterface::getImplementations() is deprecated.

It's probably a good idea to set the core_version requirement to ^9.4 || ^10 since getImplementations was only deprecated in 9.4.

Here is a version of the patch without the changes to info.yml, so you can apply it using composer-patches. Running the patched module on D10 should e possible with https://www.drupal.org/project/backward_compatibility. Note that this is not intended to be the actual patch to resolve this issue.

I have applied and tested the patch in comment #4 , it is getting applied successfully.
There are no drupal check and upgrade status errors found , also the module in compatible to D10 .
Thus moving the issue to RTBC.

A release with d10 compatibility would be welcome!

Comment #5 has not be addressed.

I have addressed the point mentioned in #5. Please review.

Thank you.

There's a problem in latest patch.

To explain what eelkeblock said: with the code change from prudloff, we now call hasImplementations(). But this method does not exist before Drupal 9.4.

So yes, we must require 9.4+ or 10+, but we cannot accept 8 anymore or we will face this kind of issue: #3295521: Call to undefined method Drupal\Core\Extension\ModuleHandler::hasImplementations() for Drupal 9 < 9.4

Apologies for the misreading.
let me create the new patch.

Updated it now. Please review.

Thanks! :)

I couldn't get this patch to apply so I rolled a local version and stuck it in a file.

Here are the contents of the file in case it helps someone:

diff --git docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.info.yml docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.info.yml
index 1a0e13eec..f322ff847 100644
--- docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.info.yml
+++ docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.info.yml
@@ -1,7 +1,7 @@
 name: 'Node Access Rebuild Progressive'
 description: 'Rebuild node access grants in chunks'
 type: module
-core_version_requirement: ^8 || ^9
+core_version_requirement: ^9.4 || ^10
 
 # Information added by Drupal.org packaging script on 2020-06-23
 version: '2.0.0'
diff --git docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.module docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.module
index 45f7c8a41..d2fc50637 100644
--- docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.module
+++ docroot/modules/contrib/node_access_rebuild_progressive/node_access_rebuild_progressive.module
@@ -36,7 +36,7 @@ function node_access_rebuild_progressive_trigger() {
   node_access_needs_rebuild(FALSE);
   // Add default grants in the unlikely case
   // no modules implement node_grants anymore.
-  if (!count(\Drupal::moduleHandler()->getImplementations('node_grants'))) {
+  if (!count(\Drupal::moduleHandler()->hasImplementations('node_grants'))) {
     node_access_rebuild_progressive_set_default();
     return node_access_rebuild_progressive_finished();
   }

I added it as node_access_rebuild_progressive_d10.patch in my patches folder

Here are the relevant lines in composer.json:

        "patches": {
            "drupal/node_access_rebuild_progressive": {
                "Automated Drupal 10 compatibility fixes - 3288770": "patches/node_access_rebuild_progressive_d10.patch"
            }

@selwynpolit - solved it for me.

Thanks

Re-rolled using relative paths in the diffs.

With any luck #3388337: Offer to co-maintain Node Access Rebuild Progressive will be resolved in another week or so, and we can hope for some movement on this. 🤞

Added @shelane as mantainer

Thanks. I've rolled this into the 2.x branch. There are a couple of minor updates I would like to apply before a new release. That should happen next week.

Not really sure about this fix..

count expects to get array|Countable parameter and \Drupal::moduleHandler()->hasImplementations returns bool.

See https://www.php.net/manual/en/function.count.php & https://www.drupal.org/node/3000490

So the correct way would be to:

if (!\Drupal::moduleHandler()->hasImplementations('node_grants')) {

So anyone tested the command drush node-access-rebuild-progressive and it runs without errors...?

Also node_access_rebuild_progressive_finished() returns void so the next line:

return node_access_rebuild_progressive_finished(); is at best misleading.

@oakulm is correct. Patch in #17 and thus the re-rolled #18 is incorrect. Resulting in the [error] TypeError: count(): Argument #1 ($value) must be of type Countable|array, bool given fatal. Patch #13 is implemented correctly but needs re-rolled.

Here's the re-rolled patch #13.

And again because last one didn't apply cleanly.

And again...

Thank you. Yes, good catch.

Look like we pushed the wrong fix :(

should be
if (!\Drupal::moduleHandler()->hasImplementations('node_grants')) {
but we pushed
if (\Drupal::moduleHandler()->hasImplementations('node_grants')) {

This will be fixed by #3415406: All entries in the node_access table get deleted when running node-access-rebuild-progressive.

thx