CommentFileSizeAuthor
#10 nivo_slider.patch371 bytesSwetha Yarla
#7 nivo_slider.patch371 bytesSwetha Yarla
#4 nivo_slider.patch371 bytesSwetha Yarla
nivo_slider.patch371 bytesSwetha Yarla
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Swetha Yarla created an issue. See original summary.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, nivo_slider.patch, failed testing.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
Status: Needs work » Needs review
FileSize
nivo_slider.patch371 bytes
Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented

Status: Needs review » Needs work

The last submitted patch, 4: nivo_slider.patch, failed testing.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
FileSize
nivo_slider.patch371 bytes

As of Drupal 8 all JS needs to follow our JavaScript coding standards. For this we use ESLint to check most of our standards.

Here is the summary of running ESLint on this module JS:
✖ 2 problems (2 errors, ZZZ warnings)

Attached is the full list of errors found by ESLint.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: nivo_slider.patch, failed testing.

Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
Issue summary: View changes
FileSize
nivo_slider.patch371 bytes
Swetha Yarla’s picture

Swetha Yarla CreditAttribution: Swetha Yarla at Melity commented
Status: Needs work » Needs review
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: Swetha Yarla » andrey.troeglazov

  • andrey.troeglazov committed bfc54f2 on 8.x-1.x 
    Issue #2696157 by Swetha Yarla, andrey.troeglazov: Nivo Slider ESLint...
andrey.troeglazov’s picture

andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented
Assigned: andrey.troeglazov » Unassigned
Status: Needs review » Fixed

Commited into dev branch. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.