Title of the link of the $site_name and $logo_image are empty [#807800]

Problem:
If you try to move the mouse pointer above the site_name the 'title' of the anchor is empty.

Description:
In the template.php file the ninesixty_preprocess_page() function contains the 'title' was outside of the 'attributes' array, because behind the 'rel' item there was a closing round brackets.

Solution:
The attached patch handles this problem correctly.

Comment	File	Size	Author
#7	ninesixty-807800.patch	1.52 KB	Webappz
#3	960_link.patch.txt	1.27 KB	Webappz
#1	960_link.patch	1.27 KB	Webappz

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Webappz CreditAttribution: Webappz commented 24 May 2010 at 14:37

File	Size
960_link.patch	1.27 KB

Sorry, I post the patch.

Comment #2

Webappz CreditAttribution: Webappz commented 24 May 2010 at 14:38

Comment #3

Webappz CreditAttribution: Webappz commented 24 May 2010 at 14:54

File	Size
960_link.patch.txt	1.27 KB

Sorry for mistakes, but it is my first patch.

Comment #4

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 24 May 2010 at 19:21

Status:

Needs review

» Reviewed & tested by the community

Looks good! Altough I do not like those long code lines and I prefer multi line if's I do mark it as reviewed.

maybe it's a good idea to make some code improvements directly?

Comment #5

Webappz CreditAttribution: Webappz commented 25 May 2010 at 12:43

Assigned:

Webappz

» Unassigned

@Nick_vh: I thanks to you to check and test my patch.
I agree with you, because I also do not like long code lines, but unfortunately the most themes use the long version.
If you create a subtheme which based on ninesixty - I also did it - you can modify it easily.

Comment #6

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 25 May 2010 at 23:21

It's not because most of them do that you are not allowed to not do that ;-)
http://drupal.org/coding-standards tells somewhere that 80 characters are the maximum for lines including arrays so go ahead and submit that altered patch!

Comment #7

Webappz CreditAttribution: Webappz commented 26 May 2010 at 13:09

File	Size
ninesixty-807800.patch	1.52 KB

@Nick_vh I thanks to you your advice.
I modified the code and I hope it will be good. :)

Comment #8

dvessel CreditAttribution: dvessel commented 26 May 2010 at 17:48

Thanks for the patch!

Unfortunately, I screwed up with managing the CVS 1.x branch and it's something I can't get into now but I'll get this fix in. I thought I could get in a 1.5 version with some hefty updates but I didn't branch for it. Now 1.x is a mess. Hah, I'll get it straightened out.