This line in reset.css adds 1-2 pixels of white space at the bottom of the <body> element:

body {
  line-height: 1;
}

Removing line-height: 1; fixes the problem. I've attached before/after shots to illustrate.

CommentFileSizeAuthor
#5 reset_pixel_error_no_clearfix.png10.75 KBTodd Nienkerk
reset_pixel_error_after.png12.11 KBTodd Nienkerk
reset_pixel_error_before.png11.32 KBTodd Nienkerk
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Todd Nienkerk’s picture

Todd Nienkerk CreditAttribution: Todd Nienkerk commented

Also, this can't be overridden in another CSS file. The line has to be removed from reset.css completely in order to close the gap.

Christopher Herberte’s picture

Christopher Herberte CreditAttribution: Christopher Herberte commented

Could we do without the reset.css? It causes many headaches and I keep wondering is it really necessary?

dvessel’s picture

dvessel CreditAttribution: dvessel commented

I suspect it's due to the clearfix class + the line height. But yeah, this should be rethought so nothing seems forced. For now, just add this into your sub-theme's .info file to remove it.

stylesheets[all][] = styles/framework/reset.css

Without the file in your sub-theme, it'll be omitted.

Christopher Herberte’s picture

Christopher Herberte CreditAttribution: Christopher Herberte commented

Yep, this is the first thing I do when creating a new sub-theme or theme base on 960. Maybe this is for a new topic but it would be nice to see a "show of hands", for and against the use of reset.css (period) -- A "nay" from me :P

Todd Nienkerk’s picture

Todd Nienkerk CreditAttribution: Todd Nienkerk commented
FileSize
reset_pixel_error_no_clearfix.png10.75 KB

I like reset.css, so I just commented out that one line.

@dvessel re: #3: I tested this without the clearfix method and still found an additional pixel at the bottom of the page. (I only tested this in Firefox, though.) See attached screenshot.

Todd Nienkerk’s picture

Todd Nienkerk CreditAttribution: Todd Nienkerk commented

Added warning to reset.css in 6.x-1.x-dev and 7.x-1.x-dev.

dvessel’s picture

dvessel CreditAttribution: dvessel commented
Status: Active » Needs review

Not sure this will still show after syncing with the latest 960.gs source since it uses another clearfix method. That body line-height was overwritten as well.

I think I'll also make it an option to include the reset file. I have some code in place to allow it to be configured from a subtheme. Just need to hook it in.

michaelfillier’s picture

michaelfillier CreditAttribution: michaelfillier commented

I am not sure what is causing my problem, but I noticed that my ninesixty sub-themes have a space (larger than 1-2px) on the bottom that I cannot figure out! See: http://maiaandassociates.ca

I am having the same problem on a development site and I cannot get it to go away. Any help would be tremendously appreciated.

dvessel’s picture

dvessel CreditAttribution: dvessel commented

@michaelfillier Look at #footer-sub and the .clear-block you added to that. Remove it. It's not related to the reset.css from the theme. It's a combination of Drupal core's .clear-block and the line-height you added to the body.