It was there before, but not anymore. Maybe it disappeard after upgrade - I'm not sure....

Any solution anyone?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sveina’s picture

Assigned: sveina » Unassigned
andrewmacpherson’s picture

Component: User interface » Code
Category: support » bug
Status: Active » Needs review
FileSize
404 bytes

This is a bug. I'm happy to say I've found the solution.

I noticed that some nodes did not have the "Submitted by" info, but others did. It wasn't dependent on the node's content type. I scratched my head for some time before noticing that the submission info was only displayed for nodes that had taxonomy terms assigned to them.

The bug is in Newsflash's node.tpl.php file:

  <?php if ($terms) { ?>
    <span class="submitted"><?php print $submitted?></span> <span class="taxonomy"><?php print $terms?></span>
  <?php }; ?>

The template checks for taxonomy terms, and if the node has some, then the terms and the submission info are displayed. Without terms, the submission info is not displayed.

To fix the problem, the submission info needs to be handled outside of this condition. Here is my suggestion to replace the above buggy code:

  <?php if ($submitted): ?>
    <span class="submitted"><?php print $submitted; ?></span>
  <?php endif; ?>
  
  <?php if ($terms): ?>
    <span class="taxonomy"><?php print $terms; ?></span>
  <?php endif; ?>

This bug affects both 5.x-1.6 and 6.x-1.6 versions of Newsflash.
Examining the code for Newsflash versions 5.x-1.2 and 5.x-1.3 assures me that those versions are unaffected; the bug was introduced with the 1.6 versions.

andrewmacpherson’s picture

An alternative fix, if you don't fancy mucking around with patches, would be to substitute the node.tpl.php from version 5.x-1.3 for the buggy version from 5.x-1.6,

Dave Hirschman’s picture

Subscribing

andrewmacpherson’s picture

Priority: Normal » Critical

Marking this as critical since it renders the submission info unusable for installations where the settings are otherwise correct, i.e. post info is enabled at admin/build/themes/settings.

andrewmacpherson’s picture

Status: Needs review » Patch (to be ported)
FileSize
849 bytes

better version of the patch

Kisugi Ai’s picture

Status: Patch (to be ported) » Closed (fixed)

closed -- issue fixed for 2 weeks with no activity.

keypetery’s picture

Patch in #6 seems to have worked for me, even though I am using 6.x-1.6. Just implemented, so may find issues later.

Thx Andrew