This patch changes a PHP short tag (<?) to a regular PHP tag (<?php) in the mytube.install file, according to Drupal's coding standards. The patch applies to the 6.x-1.x branch.

CommentFileSizeAuthor
mytube-php_short_tag.patch186 bytestheunraveler
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

l@va’s picture

l@va CreditAttribution: l@va commented
Assigned: Unassigned » l@va
Priority: Normal » Minor
Status: Active » Fixed

Hi, sorry it took so long to get back to you on this. Due to my living arrangements I have limited internet access, so while I could see the issue from my phone, testing and pushing changes back to git would have been difficult. I'm nonetheless happy to see people are looking through and building upon this module.

As for the patch itself, I can't believe it wasn't already compliant. Someone else had that issue a long time ago when reviewing my code in the CVS application, but somehow it completely slipped my mind to make sure the mytube.install followed the same standard. I just committed it, and your change will be included in the next update for all versions with due credit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

C-Logemann’s picture

C-Logemann
Primary language German
Location Frankfurt/M, Germany
CreditAttribution: C-Logemann commented
Issue summary: View changes

It's not only a coding standard for good looking code. On a customer server with php flag "short_open_tag Off" I had some strange behavior with just these mytube.install file. Its content was shown in the browser. I hope we get a stable version soon where this is fixed.

@l@va: I believe you need one or two co-maintainer. It's always helpful even if you don't have problems with your internet access.