I'm very interested in using this plugin, so following up on #612304: Avoid hard coding database credentials in the script, I refactored the module to work with Drush instead of hard-coded database credentials. I also changed the structure a little so it saves the active plugins in a settings form, and modified the README accordingly.

Patch and tarball of the modified module are attached.
Thanks for doing the hard work figuring out the Munin output syntax. I'd be happy to co-maintain this module if you're looking for help.

CommentFileSizeAuthor
#2 munin-refactored.tgz10.08 KBthebuckst0p
#2 munin-refactoring-2.patch14.96 KBthebuckst0p
munin-refactored.tgz9.9 KBthebuckst0p
munin-refactoring.patch13.89 KBthebuckst0p

Comments

geerlingguy’s picture

geerlingguy commented

Subscribe... Things would be much nicer coming through Drush; that way this module stays simpler.

thebuckst0p’s picture

thebuckst0p commented
StatusFileSize
new munin-refactoring-2.patch14.96 KB
new munin-refactored.tgz10.08 KB

There were some bugs in the previous attachments with the drush command, and I forgot to include ROOT and URI parameters. Should be fixed now.
Maybe this should be a 2.x branch of the module... I'm happy to commit that if the maintainer wants a co-maintainer.

thebuckst0p’s picture

thebuckst0p commented

McGo gave me maintainer access, so I created a new 6.x-2.x branch and 6.x-2.x-dev release with the new code (should go live in a few minutes).
Feedback is welcome.

geerlingguy’s picture

geerlingguy commented

Awesome. I'll check it out when I get a chance (which might be a couple weeks, unfortunately). Thanks for your work here!

thebuckst0p’s picture

thebuckst0p commented

I'm not sure why it's taking so long for the release to be published... if it's not live tomorrow, I'll post an issue to the infrastructure queue. Maybe it's just slow because it's a dev release (I thought it was faster with the new Git system but I guess not).

geerlingguy’s picture

geerlingguy commented

A few notes:

For the users graph, instead of

curuser.label Currently logged in user

It should probably be plural.

Also, for queries used with sql-query, wouldn't count(*) be faster than count([column-name])? See: http://www.mysqlperformanceblog.com/2007/04/10/count-vs-countcol/

Just a couple quick suggestions. I'm forward-porting the actual scripts for one of my Drupal 7 sites, don't have time right now to port this module to D7, but might take a crack at that soon.

Alex Savin’s picture

Alex Savin commented
Status: Needs review » Closed (fixed)