Problem/Motivation

When switching between workspace, the block content is not available until clear the cache.

Steps to reproduce

1. On LIVE workspace: Create a custom block and assign to a region visible on home page.
2. Switch to stage and clear cache
3. Switch back to LIVE workspace.

Expected
See block added in step 1 is visible

Actual:
See 'This block is broken or missing. You may be missing content or you might need to enable the original module.'
The block wouldn't appear back until resave or clear cache in LIVE workspace.

Originally reported by @sirko_el

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#18 2944805-18.patch12.94 KBtimmillwood
#16 2944805-16.patch12.96 KBtimmillwood
#16 interdiff-2944805-16.txt6.78 KBtimmillwood
#14 2944805-14.patch11.59 KBtimmillwood
#14 interdiff-2944805-14.txt821 bytestimmillwood
#11 2944805-11.patch11.51 KBtimmillwood
#11 interdiff-2944805-11.txt5.4 KBtimmillwood
#9 2944805-9.patch13.24 KBtimmillwood
#9 interdiff-2944805-9.txt6.78 KBtimmillwood
#6 2944805-6.patch8.39 KBtimmillwood
#6 2944805-6-test-only.patch5.93 KBtimmillwood
#2 2944805-2.patch5.93 KBtimmillwood
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85 created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Active » Needs review
FileSize
2944805-2.patch5.93 KB

Here's a test patch for this:

Status: Needs review » Needs work

The last submitted patch, 2: 2944805-2.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Project: Workspace » Multiversion
Status: Needs work » Needs review

Moving to Multiversion, because that's where it needs fixing.

Status: Needs review » Needs work

The last submitted patch, 2: 2944805-2.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
2944805-6-test-only.patch5.93 KB
2944805-6.patch8.39 KB

Here's a fix

The last submitted patch, 6: 2944805-6-test-only.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 6: 2944805-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
interdiff-2944805-9.txt6.78 KB
2944805-9.patch13.24 KB
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented

Thanks @timmillwood. I applied the patch and it fixes the broken block.

If we have more than one user logged in and do the steps 1 and 2 in "steps to reproduce" in one session, the other users get the issue.
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
FileSize
interdiff-2944805-11.txt5.4 KB
2944805-11.patch11.51 KB

This should fix the multi user issue by decorating the BlockManager, and overriding the cache key whenever it's used. I tried to override it in the constructor, although this is loaded really early and often isn't rebuilt when switching workspaces.

Status: Needs review » Needs work

The last submitted patch, 11: 2944805-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented

Looks much cleaner. Few comments:

  1. +++ b/multiversion.services.yml
@@ -66,6 +66,12 @@ services:
+    decoration_priority: 50

    Not sure how this affect anyway or why 50. 

  2. +++ b/src/Block/BlockManager.php
@@ -0,0 +1,43 @@
+    $active_workspace = \Drupal::service('workspace.manager')->getActiveWorkspace();
...
+    $active_workspace = \Drupal::service('workspace.manager')->getActiveWorkspace();
...
+    $active_workspace = \Drupal::service('workspace.manager')->getActiveWorkspace();

    probably, we can inject it in decorator?

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
interdiff-2944805-14.txt821 bytes
2944805-14.patch11.59 KB

Looks like the cache is cleared before the workspace table is created.

Status: Needs review » Needs work

The last submitted patch, 14: 2944805-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
interdiff-2944805-16.txt6.78 KB
2944805-16.patch12.96 KB

Fixing #13 and #14.

Status: Needs review » Needs work

The last submitted patch, 16: 2944805-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
2944805-18.patch12.94 KB

timmillwood credited jeqq.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

  • timmillwood committed c66a6d2 on 8.x-1.x 
    Issue #2944805 by timmillwood, vijaycs85, jeqq: Switching workspace...
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented
Status: Needs review » Fixed

timmillwood credited sirko_el.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
CreditAttribution: timmillwood at Appnovation for Pfizer, Inc. commented

I should've credited @sirko_el

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.